You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2021/07/27 17:41:37 UTC
[kudu-CR] KUDU-1921 Add ability to require authn/encryption to Java client
Attila Bukor has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17732
Change subject: KUDU-1921 Add ability to require authn/encryption to Java client
......................................................................
KUDU-1921 Add ability to require authn/encryption to Java client
Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
7 files changed, 135 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/17732/1
--
To view, visit http://gerrit.cloudera.org:8080/17732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
Gerrit-Change-Number: 17732
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
[kudu-CR] [java] KUDU-1921 Add ability to require authn/encryption to Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17732
to look at the new patch set (#7).
Change subject: [java] KUDU-1921 Add ability to require authn/encryption to Java client
......................................................................
[java] KUDU-1921 Add ability to require authn/encryption to Java client
Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
7 files changed, 186 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/17732/7
--
To view, visit http://gerrit.cloudera.org:8080/17732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
Gerrit-Change-Number: 17732
Gerrit-PatchSet: 7
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] KUDU-1921 Add ability to require authn/encryption to Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17732
to look at the new patch set (#8).
Change subject: [java] KUDU-1921 Add ability to require authn/encryption to Java client
......................................................................
[java] KUDU-1921 Add ability to require authn/encryption to Java client
Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
7 files changed, 187 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/17732/8
--
To view, visit http://gerrit.cloudera.org:8080/17732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
Gerrit-Change-Number: 17732
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] KUDU-1921 Add ability to require authn/encryption to Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17732
to look at the new patch set (#5).
Change subject: [java] KUDU-1921 Add ability to require authn/encryption to Java client
......................................................................
[java] KUDU-1921 Add ability to require authn/encryption to Java client
Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
7 files changed, 172 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/17732/5
--
To view, visit http://gerrit.cloudera.org:8080/17732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
Gerrit-Change-Number: 17732
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] KUDU-1921 Add ability to require authn/encryption to Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17732 )
Change subject: [java] KUDU-1921 Add ability to require authn/encryption to Java client
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17732/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java:
http://gerrit.cloudera.org:8080/#/c/17732/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@574
PS8, Line 574:
> Sure, added it.
Thank you!
--
To view, visit http://gerrit.cloudera.org:8080/17732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
Gerrit-Change-Number: 17732
Gerrit-PatchSet: 9
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 10 Aug 2021 16:32:20 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-1921 Add ability to require authn/encryption to Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17732 )
Change subject: [java] KUDU-1921 Add ability to require authn/encryption to Java client
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17732/2/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
File java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java:
http://gerrit.cloudera.org:8080/#/c/17732/2/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java@382
PS2, Line 382: negotiatedTls
What if the negotiated TLS is auth-only, without encryption and integrity? Should the client bail or it's OK to continue?
--
To view, visit http://gerrit.cloudera.org:8080/17732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
Gerrit-Change-Number: 17732
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 27 Jul 2021 23:38:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-1921 Add ability to require authn/encryption to Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17732
to look at the new patch set (#2).
Change subject: [java] KUDU-1921 Add ability to require authn/encryption to Java client
......................................................................
[java] KUDU-1921 Add ability to require authn/encryption to Java client
Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
7 files changed, 135 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/17732/2
--
To view, visit http://gerrit.cloudera.org:8080/17732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
Gerrit-Change-Number: 17732
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] KUDU-1921 Add ability to require authn/encryption to Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17732 )
Change subject: [java] KUDU-1921 Add ability to require authn/encryption to Java client
......................................................................
[java] KUDU-1921 Add ability to require authn/encryption to Java client
Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
Reviewed-on: http://gerrit.cloudera.org:8080/17732
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
7 files changed, 201 insertions(+), 10 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
Gerrit-Change-Number: 17732
Gerrit-PatchSet: 10
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] KUDU-1921 Add ability to require authn/encryption to Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17732
to look at the new patch set (#9).
Change subject: [java] KUDU-1921 Add ability to require authn/encryption to Java client
......................................................................
[java] KUDU-1921 Add ability to require authn/encryption to Java client
Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
7 files changed, 201 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/17732/9
--
To view, visit http://gerrit.cloudera.org:8080/17732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
Gerrit-Change-Number: 17732
Gerrit-PatchSet: 9
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] KUDU-1921 Add ability to require authn/encryption to Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17732 )
Change subject: [java] KUDU-1921 Add ability to require authn/encryption to Java client
......................................................................
Patch Set 8: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
Gerrit-Change-Number: 17732
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 09 Aug 2021 18:23:21 +0000
Gerrit-HasComments: No
[kudu-CR] [java] KUDU-1921 Add ability to require authn/encryption to Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.
Change subject: [java] KUDU-1921 Add ability to require authn/encryption to Java client
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
Gerrit-Change-Number: 17732
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] KUDU-1921 Add ability to require authn/encryption to Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17732
to look at the new patch set (#3).
Change subject: [java] KUDU-1921 Add ability to require authn/encryption to Java client
......................................................................
[java] KUDU-1921 Add ability to require authn/encryption to Java client
Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
7 files changed, 137 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/17732/3
--
To view, visit http://gerrit.cloudera.org:8080/17732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
Gerrit-Change-Number: 17732
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] KUDU-1921 Add ability to require authn/encryption to Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17732 )
Change subject: [java] KUDU-1921 Add ability to require authn/encryption to Java client
......................................................................
Patch Set 9:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/17732/8/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/17732/8/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2735
PS8, Line 2735: // Only connects to remote servers that support encryption, fails
: // otherwise. It can connect to insecure servers only locally.
: REQUIRED_REMOTE,
: // Only connects to any server, including on the loopback interface,
: // that support encryption, fails otherwise.
: REQUIRED,
> nit: consider renaming these as well per suggestion at https://gerrit.cloud
Done
http://gerrit.cloudera.org:8080/#/c/17732/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java:
http://gerrit.cloudera.org:8080/#/c/17732/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@574
PS8, Line 574:
> While you are working on this, do you mind adding one extra test scenario t
Sure, added it.
--
To view, visit http://gerrit.cloudera.org:8080/17732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
Gerrit-Change-Number: 17732
Gerrit-PatchSet: 9
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 10 Aug 2021 14:18:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] KUDU-1921 Add ability to require authn/encryption to Java client
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17732
to look at the new patch set (#4).
Change subject: [java] KUDU-1921 Add ability to require authn/encryption to Java client
......................................................................
[java] KUDU-1921 Add ability to require authn/encryption to Java client
Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectionCache.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduClient.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
7 files changed, 142 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/17732/4
--
To view, visit http://gerrit.cloudera.org:8080/17732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
Gerrit-Change-Number: 17732
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] KUDU-1921 Add ability to require authn/encryption to Java client
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17732 )
Change subject: [java] KUDU-1921 Add ability to require authn/encryption to Java client
......................................................................
Patch Set 8: Code-Review+1
(2 comments)
Overall looks good to me, just the same naming nit as for the C++ client and a request to add one extra test scenario.
http://gerrit.cloudera.org:8080/#/c/17732/8/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/17732/8/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2735
PS8, Line 2735: // Only connects to remote servers that support encryption, fails
: // otherwise. It can connect to insecure servers only locally.
: REQUIRED,
: // Only connects to any server, including on the loopback interface,
: // that support encryption, fails otherwise.
: REQUIRED_LOOPBACK,
nit: consider renaming these as well per suggestion at https://gerrit.cloudera.org/#/c/17731/8/src/kudu/client/client.h@238
http://gerrit.cloudera.org:8080/#/c/17732/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java:
http://gerrit.cloudera.org:8080/#/c/17732/8/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@574
PS8, Line 574: }
While you are working on this, do you mind adding one extra test scenario to verify that a client with encryption policy AsyncKuduClient.EncryptionPolicy.OPTIONAL (the default setting) is able to connect to a cluster running with "--rpc_encryption=disabled", "--rpc_authentication=disabled" flags? I thought we had such a test scenario in TestSecurity or elsewhere, but I didn't find such a scenario anywhere for Java Kudu client, actually.
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/17732
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic951b2090a4933eca70dc53b6f93cdcff5a74929
Gerrit-Change-Number: 17732
Gerrit-PatchSet: 8
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 09 Aug 2021 22:18:33 +0000
Gerrit-HasComments: Yes