You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@weex.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/07/08 09:07:00 UTC

[jira] [Commented] (WEEX-496) In CoreText mode, origin of first line is incorret under iOS9 or lower

    [ https://issues.apache.org/jira/browse/WEEX-496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16536037#comment-16536037 ] 

ASF GitHub Bot commented on WEEX-496:
-------------------------------------

GitHub user wqyfavor opened a pull request:

    https://github.com/apache/incubator-weex/pull/1312

    [WEEX-496][iOS] In CoreText mode, origin of first line is incorret un…

    …der iOS9 or lower.
    
    First of all, thank you for your contribution! 
    
    Please makes sure that these checkboxes are checked before submitting your PR, thank you!
    
    <!-- 
    How to use github markdown?
    ### checkable example
    - [x] checked
    - [ ] not checked
    More github Markdown info to see https://guides.github.com/features/mastering-markdown/
    -->
    
    CheckList:
    
    **if** *isBugFix* **:**
    
      * [ ] Make sure that you add at least one unit test for the bug which you had fixed.
    
    **elif** *isNewFeature* **:**
    
      * [ ] Update API docs for the component.
      * [ ] Update/Add demo to demonstrate new feature.
      * [ ] Update test scripts for the feature.
      * [ ] Add unit tests for the feature.
    
    <!--
    (请在***提交***前删除这段描述)
    
    Notes: Weex will move into Apache Software Foundation (ASF) on Feb 24 2017.
    
    Our new GitHub repo is https://github.com/apache/incubator-weex
    
    After Feb 24 2017, we only accept pull requests from https://github.com/apache/incubator-weex
    
    Thank you for your support.
    
    ----
    
    注意:Weex 将于 2017-02-24 迁移至 Apache 基金会
    
    届时我们会使用新的 GitHub 仓库:https://github.com/apache/incubator-weex 并在那里继续接受大家的 pull request。
    
    更多详情请关注:https://github.com/weexteam/article/issues/130
    
    感谢理解和支持
    
    -->
    
    <!--
    (请在***提交***前删除这段描述)
    It's ***RECOMMENDED*** to submit typo fix, new demo, tiny bugfix and large feature to `master` branch.
        
    See [Branch Strategy](https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management) for more detail.
    
    ----
    
    错别字修改、新 demo、较小的 bugfix、甚至较大的功能都可以直接提到 `master` 分支;
    
    查看完整的[分支策略 (英文)](https://github.com/alibaba/weex/blob/dev/CONTRIBUTING.md#branch-management)。
    
    -->


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wqyfavor/incubator-weex fix-coretext2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-weex/pull/1312.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1312
    
----
commit 402feabd796476d9d95d515a4919d0dae10407ff
Author: 神漠 <qi...@...>
Date:   2018-07-08T09:05:09Z

    [WEEX-496][iOS] In CoreText mode, origin of first line is incorret under iOS9 or lower.

----


> In CoreText mode, origin of first line is incorret under iOS9 or lower
> ----------------------------------------------------------------------
>
>                 Key: WEEX-496
>                 URL: https://issues.apache.org/jira/browse/WEEX-496
>             Project: Weex
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: 0.19
>            Reporter: Wang Qianyuan
>            Assignee: xingZhang
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)