You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "aeroyorch (via GitHub)" <gi...@apache.org> on 2026/06/11 22:19:35 UTC
[PR] Document `apply_function` dot notation requirement for Kafka message queues [airflow]
aeroyorch opened a new pull request, #68414:
URL: https://github.com/apache/airflow/pull/68414
Add some docs about `apply_function` dot notation requirement for Kafka message queues.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
For user-facing UI changes, please attach before/after screenshots (or a short
screen recording) so reviewers can assess the visual impact.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document `apply_function` dot notation requirement for Kafka message queues [airflow]
Posted by "aeroyorch (via GitHub)" <gi...@apache.org>.
aeroyorch commented on PR #68414:
URL: https://github.com/apache/airflow/pull/68414#issuecomment-4900899587
> Verified against current `main` (`queues/kafka.py`, `triggers/await_message.py`) — the required-for-queue / optional-for-sensor split, the `None` → `message.value().decode("utf-8")` fallback, and message-as-last-positional-arg all check out.
>
> One wording nit on the return contract, since that's exactly what this new section documents: the trigger gates on a truthy check (`if event:`), not `is not None`. So a function that returns a falsy-but-valid value (`0`, `0.0`, `""`, `[]`, `{}`, `False`) is treated as "no match" and polling continues, same as returning `None`. A predicate written straight from the example above — `return val["amount"] > threshold` — would silently never fire when it evaluates to `False`. The "returns any data" phrasing is inherited from the existing trigger docstring / `sensors.rst`, so it's a pre-existing ambiguity, but since this section is specifically about the return contract it's worth making precise here.
>
> Suggested inline edit on the line _"If it returns any data, the returned value is used as the payload of the `TriggerEvent`. Otherwise the trigger continues polling."_:
>
> > If it returns a truthy value, that value is used as the payload of the `TriggerEvent`. If it returns a falsy value (`None`, `0`, `False`, `""`, `[]`, ...), the trigger keeps polling.
thanks, you're right. Review implemented :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document `apply_function` dot notation requirement for Kafka message queues [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 merged PR #68414:
URL: https://github.com/apache/airflow/pull/68414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org