You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by gi...@git.apache.org on 2017/05/12 22:50:18 UTC

[GitHub] nickva commented on issue #495: Couchdb 3288 mixed cluster upgrade

nickva commented on issue #495: Couchdb 3288 mixed cluster upgrade
URL: https://github.com/apache/couchdb/pull/495#issuecomment-301202995
 
 
   This is a nice cleanup of code even outside the context of PSE. More functions instead of records everywhere, `couch_server` looks more sane, some new helpers in couch_db module.
   
   I ran couchdyno's replicator tests https://github.com/cloudant-labs/couchdyno/blob/master/README_tests.md 
   
   Then a few custom scripts which do concurrent db and doc creations. Here is one of them:
   
   https://gist.github.com/nickva/d0e0813c7039ba824489fb017159f1be 
   
   It turns out 500 conflict errors is something we return on db creation sometimes, that was a surprise for me. But master behaves the same, so it's not an issue with this PR
   
   Then with  `./dev/run` setup killed `node3` and re-spawned it with master code and ran some tests on the mixed cluster.
   
   Didn't find any issues during testing
   
   +1
   
   Nice work @davisp
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services