You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/08/22 11:44:42 UTC
[GitHub] [accumulo] dlmarion opened a new pull request, #2887: Print exceptions that cause the server process to exit to stderr
dlmarion opened a new pull request, #2887:
URL: https://github.com/apache/accumulo/pull/2887
Async Logging may not flush the exception to the file before the
process terminates. Print the error to stderr as well.
Closes #2885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on a diff in pull request #2887: Print exceptions that cause the server process to exit to stderr
Posted by GitBox <gi...@apache.org>.
EdColeman commented on code in PR #2887:
URL: https://github.com/apache/accumulo/pull/2887#discussion_r951506130
##########
start/src/main/java/org/apache/accumulo/start/Main.java:
##########
@@ -51,26 +51,23 @@ public static void main(final String[] args) throws Exception {
var deprecatedConfClass = org.apache.accumulo.start.classloader.AccumuloClassLoader
.getClassLoader().loadClass("org.apache.hadoop.conf.Configuration");
confClass = deprecatedConfClass;
+ Object conf = null;
Review Comment:
null initializer is redundant (as is the one for `confClass` at line 48)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] EdColeman commented on a diff in pull request #2887: Print exceptions that cause the server process to exit to stderr
Posted by GitBox <gi...@apache.org>.
EdColeman commented on code in PR #2887:
URL: https://github.com/apache/accumulo/pull/2887#discussion_r951516946
##########
start/src/main/java/org/apache/accumulo/start/Main.java:
##########
@@ -51,26 +51,23 @@ public static void main(final String[] args) throws Exception {
var deprecatedConfClass = org.apache.accumulo.start.classloader.AccumuloClassLoader
.getClassLoader().loadClass("org.apache.hadoop.conf.Configuration");
confClass = deprecatedConfClass;
+ Object conf = null;
Review Comment:
While you are in the neighborhood - its a chance to remove a checkstyle warning and a) means we don't need to clean it up later and b) makes finding other checkstyle issues because there would be 2 fewer if you fix both now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion merged pull request #2887: Print exceptions that cause the server process to exit to stderr
Posted by GitBox <gi...@apache.org>.
dlmarion merged PR #2887:
URL: https://github.com/apache/accumulo/pull/2887
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] dlmarion commented on a diff in pull request #2887: Print exceptions that cause the server process to exit to stderr
Posted by GitBox <gi...@apache.org>.
dlmarion commented on code in PR #2887:
URL: https://github.com/apache/accumulo/pull/2887#discussion_r951509949
##########
start/src/main/java/org/apache/accumulo/start/Main.java:
##########
@@ -51,26 +51,23 @@ public static void main(final String[] args) throws Exception {
var deprecatedConfClass = org.apache.accumulo.start.classloader.AccumuloClassLoader
.getClassLoader().loadClass("org.apache.hadoop.conf.Configuration");
confClass = deprecatedConfClass;
+ Object conf = null;
Review Comment:
Redundant, but not an error / issue. I assume the compiler does the right thing. I didn't write it, I just moved lines around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #2887: Print exceptions that cause the server process to exit to stderr
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #2887:
URL: https://github.com/apache/accumulo/pull/2887#issuecomment-1235685953
Ideally, instead of explicitly printing, we should just make sure the exception gets thrown out of the main method... let the JVM do its own printing to STDERR, as this is the expected behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org