You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/11/28 14:11:07 UTC

[GitHub] [calcite] jinxing64 commented on a change in pull request #1613: [CALCITE-3542] Implement RepeatUnion All=false

jinxing64 commented on a change in pull request #1613: [CALCITE-3542] Implement RepeatUnion All=false
URL: https://github.com/apache/calcite/pull/1613#discussion_r351794095
 
 

 ##########
 File path: linq4j/src/main/java/org/apache/calcite/linq4j/EnumerableDefaults.java
 ##########
 @@ -3845,67 +3850,94 @@ public void close() {
           private final Enumerator<TSource> seedEnumerator = seed.enumerator();
           private Enumerator<TSource> iterativeEnumerator = null;
 
+          // Set to control duplicates, only used if all is false
 
 Review comment:
   Nit: shall we give a double quotes for `all` ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services