[GitHub] [carbondata] akashrn5 commented on a change in pull request #3219: [CARBONDATA-3385]consider the merge index file also during clean files for compatibility case

[GitBox <gi...@apache.org>]

akashrn5 commented on a change in pull request #3219: [CARBONDATA-3385]consider the merge index file also during clean files for compatibility case
URL: https://github.com/apache/carbondata/pull/3219#discussion_r284154689
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/util/DeleteLoadFolders.java
 ##########
 @@ -128,7 +128,8 @@ private static void physicalFactAndMeasureMetadataDeletion(CarbonTable carbonTab
 
                 @Override public boolean accept(CarbonFile file) {
                   return (CarbonTablePath.isCarbonDataFile(file.getName()) ||
-                      CarbonTablePath.isCarbonIndexFile(file.getName()));
+                      CarbonTablePath.isCarbonIndexFile(file.getName()) ||
+                      CarbonTablePath.isCarbonMergeIndexFile(file.getName()));
 
 Review comment:
   actully for isIndexFile method, we are checking for startswith, so it considers merge index file also, as file extension is .carbonindexmerge. So this change is not required may be.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services