You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2019/08/25 22:29:44 UTC

[GitHub] [activemq-artemis] michaelpearce-gain edited a comment on issue #2802: ARTEMIS-2457 implement ring queue

michaelpearce-gain edited a comment on issue #2802: ARTEMIS-2457 implement ring queue
URL: https://github.com/apache/activemq-artemis/pull/2802#issuecomment-524669540
 
 
   Looking better, left a number of comments, one critical bug i found was its possible to raise NPE in QueueImpl constructor, this is because its not following the same pattern as all other fields, lets keep things uniform / follow existing convention, this way avoids issues such as this, and also people get used to certain area's expecting to do own certain responsibility when debugging etc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services