[GitHub] [incubator-druid] sashidhar commented on a change in pull request #7969: Making StatusResponseHandler singleton and fixing all its instantiation invocations

[GitBox <gi...@apache.org>]

sashidhar commented on a change in pull request #7969: Making StatusResponseHandler singleton and fixing all its instantiation invocations
URL: https://github.com/apache/incubator-druid/pull/7969#discussion_r298253694
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/java/util/http/client/response/StatusResponseHandler.java
 ##########
 @@ -23,16 +23,24 @@
 import org.jboss.netty.handler.codec.http.HttpResponse;
 
 import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
 
 /**
  */
 public class StatusResponseHandler implements HttpResponseHandler<StatusResponseHolder, StatusResponseHolder>
 {
   private final Charset charset;
 
 Review comment:
   @leventov , you mean to replace usage (each occurrence) of **charset** instance variable in this class directly with StandardCharsets.UTF_8 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org