You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2004/02/02 21:03:05 UTC
cvs commit: jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5 CoyoteRequest.java
remm 2004/02/02 12:03:05
Modified: catalina/src/share/org/apache/coyote/tomcat5
CoyoteRequest.java
Log:
- Bug 25363: Expose the SSL attributes in getAttributeNames(). I do not see
getAttributeNames() as being performance critical (since we don't do any
stupid attribute merging in the RD anymore), so retrieving the SSL attrs if the
request is secure is just simpler. Other attibutes coming from the native layer
will not be exposed through the enumeration.
Revision Changes Path
1.30 +7 -4 jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteRequest.java
Index: CoyoteRequest.java
===================================================================
RCS file: /home/cvs/jakarta-tomcat-catalina/catalina/src/share/org/apache/coyote/tomcat5/CoyoteRequest.java,v
retrieving revision 1.29
retrieving revision 1.30
diff -u -r1.29 -r1.30
--- CoyoteRequest.java 22 Jan 2004 18:22:24 -0000 1.29
+++ CoyoteRequest.java 2 Feb 2004 20:03:05 -0000 1.30
@@ -987,6 +987,9 @@
* empty <code>Enumeration</code> if there are none.
*/
public Enumeration getAttributeNames() {
+ if (isSecure()) {
+ getAttribute(Globals.CERTIFICATES_ATTR);
+ }
return new Enumerator(attributes.keySet(), true);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: tomcat-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tomcat-dev-help@jakarta.apache.org