[GitHub] [beam] pabloem commented on a change in pull request #11229: [BEAM-9608] Increasing scope of context managers for FnApiRunner

[GitBox <gi...@apache.org>]

pabloem commented on a change in pull request #11229: [BEAM-9608] Increasing scope of context managers for FnApiRunner
URL: https://github.com/apache/beam/pull/11229#discussion_r399570204
 
 

 ##########
 File path: sdks/python/apache_beam/runners/portability/fn_api_runner/execution.py
 ##########
 @@ -245,37 +254,106 @@ class FnApiRunnerExecutionContext(object):
        ``beam.PCollection``.
  """
   def __init__(self,
-      worker_handler_factory,  # type: Callable[[Optional[str], int], List[WorkerHandler]]
+      worker_handler_manager,  # type: worker_handlers.WorkerHandlerManager
       pipeline_components,  # type: beam_runner_api_pb2.Components
       safe_coders,
       data_channel_coders,
                ):
     """
-    :param worker_handler_factory: A ``callable`` that takes in an environment
+    :param worker_handler_manager: A ``callable`` that takes in an environment
 
 Review comment:
   Done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services