[GitHub] [couchdb] janl opened a new pull request, #4349: feat(build): fail build if xref complains

[GitBox <gi...@apache.org>]

janl opened a new pull request, #4349:
URL: https://github.com/apache/couchdb/pull/4349

   only works on Erlang 23. 24 and 25 fail,
   
   24 e.g. with:
   
   ```==> mem3 (xref)
   Warning: hastings_index:await/2 is undefined function (Xref)
   Warning: hastings_index:design_doc_to_indexes/1 is undefined function (Xref)
   Warning: hastings_index_manager:get_index/2 is undefined function (Xref)
   WARN:  Continuing on after abort: [xref]
   ERROR: xref failed while processing /Users/jan/Work/asf/tmp/couchdb/src/mem3: {'EXIT',
    {{badmatch,
      [{attribute,{1,1},file,{"src/mem3_reshard_index.erl",1}},
       {attribute,{13,2},module,mem3_reshard_index},
       {attribute,
        {15,2},
        export,
        [{design_docs,1},{target_indices,2},{spawn_builders,1},{build_index,2}]},
   … big symbol dump
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] janl merged pull request #4349: feat(build): fail build if xref complains

["janl (via GitHub)" <gi...@apache.org>]

janl merged PR #4349:
URL: https://github.com/apache/couchdb/pull/4349


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [couchdb] rnewson commented on a diff in pull request #4349: feat(build): fail build if xref complains

[GitBox <gi...@apache.org>]

rnewson commented on code in PR #4349:
URL: https://github.com/apache/couchdb/pull/4349#discussion_r1062532302


##########
build-aux/xref-helper.sh:
##########
@@ -0,0 +1,23 @@
+#!/bin/sh -x
+REBAR=$1
+DIALYZE_OPTS=$2
+
+# run rebar xref, grep out rebar meta output (==> and WARN)
+# pipe the rest into a file
+$REBAR --keep-going --recursive xref $DIALYZE_OPTS | \
+                                      grep -v '==>' | \
+                                      grep -v 'WARN' | \
+                                      grep -v hastings > ./tmp/xref-output.txt
+
+# compare result against known allowed output
+mkdir -p ./tmp

Review Comment:
   mkdir should happen before first use above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org