You are viewing a plain text version of this content. The canonical link for it is here.
Posted to apreq-dev@httpd.apache.org by "Philip M. Gollucci" <pg...@p6m7g8.com> on 2005/04/17 01:25:44 UTC

[PATCH[ Re: apre2 and httpd versions

Joe Schaefer wrote:
> "Philip M. Gollucci" <pg...@p6m7g8.com> writes:
> 
> [...]
> 
> 
>>I'm hoping the correct fix is to prevent make
>>from cd'ing into modules/apache if you don't specify
>>--with-apache1-apxs and only modules/apache2
>>
>>Thoughts ?
> 
> 
> +1.
> 
Patch attached.

END
------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
	http://www.liquidityservicesinc.com

Re: [PATCH[ Re: apre2 and httpd versions

Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Joe Schaefer wrote:
> "Philip M. Gollucci" <pg...@p6m7g8.com> writes:
>>gmake:
>>	test
>>	docs
> 
> 
> You might be able to fix these though. test and docs 
> use gmake's "%.$ext" feature (cf. lines with "%.t" in 
> glue/perl/Makefile.PL and library/t/Makefile.am).
> 
> If you can rewrite those lines using more traditional
> Makefile conventions, we may be able to remove the
> gmake dependency (which would be a very good thing).
I'll definetley look at this; unfortunately probably not until next 
weekend though.  Can the FAQ.pod move to one of the pod dirs ?



-- 
END
------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
	http://www.liquidityservicesinc.com

Re: [PATCH[ Re: apre2 and httpd versions

Posted by Joe Schaefer <jo...@sunstarsys.com>.
"Philip M. Gollucci" <pg...@p6m7g8.com> writes:

[...]

> For reference:
>
> Make:
> 	all
> 	install
> 	docs_install
> 	clean
> 	docs_clean
> 	release
> 	test_release
>
> gmake:
> 	test
> 	docs

You might be able to fix these though. test and docs 
use gmake's "%.$ext" feature (cf. lines with "%.t" in 
glue/perl/Makefile.PL and library/t/Makefile.am).

If you can rewrite those lines using more traditional
Makefile conventions, we may be able to remove the
gmake dependency (which would be a very good thing).

-- 
Joe Schaefer


Re: [PATCH[ Re: apre2 and httpd versions

Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Philip M. Gollucci wrote:
> Interestingly only the docs require gmake (make all test install)
> work with FreeBSD's make. On the plus side, the
> make docs gets much father :)
make test requires gmake as well.

That explains all my unneccary patches
to
RE: [PATCH] library/t/Makefile.am (all as one)

*sigh*

For reference:

Make:
	all
	install
	docs_install
	clean
	docs_clean
	release
	test_release

gmake:
	test
	docs


END
------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
	http://www.liquidityservicesinc.com

Re: [PATCH[ Re: apre2 and httpd versions

Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Philip M. Gollucci wrote:
> Joe Schaefer wrote:
> 
>> "Philip M. Gollucci" <pg...@p6m7g8.com> writes:
>>> I'm hoping the correct fix is to prevenat make
>>> from cd'ing into modules/apache if you don't specify
>>> --with-apache1-apxs and only modules/apache2
>>>
>>> Thoughts ?
So sorry, I was using FreeBSD's make not gmake.

Interestingly only the docs require gmake (make all test install)
work with FreeBSD's make. On the plus side, the
make docs gets much father :)

If we're going to require it maybe we should check for it
upfront first ?

I read the warning in the STATUS file about using it
and it caused errors/warnings with my previous patch.

Here's one that works for FreeBSD's make and gmake

Attached.

END
------------------------------------------------------
Philip M. Gollucci (pgollucci@p6m7g8.com) 301.254.5198
Consultant / http://p6m7g8.net/Resume/resume.shtml
Senior Developer / Liquidity Services, Inc.
	http://www.liquidityservicesinc.com