You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/29 23:16:57 UTC
[GitHub] [airflow] madison-ookla opened a new pull request #13981: Upgrade tool: skip bad file test for Python 2.7
madison-ookla opened a new pull request #13981:
URL: https://github.com/apache/airflow/pull/13981
This PR addresses a test failure that was introduced in #13371 and identified by Kaxil/Jarek when syncing the `v1-10-x` branches.
I was able to reproduce the issue locally and found that Python 2.7 is able to read the file with bad bytes just fine without throwing a `UnicodeDecodeError`. Since this allows the rest of the rule to behave normally (i.e. the file is checked for the Airflow macro plugin contents), it won't raise any problems. I could set up this test to behave differently for 2.7 and 3.x respectively, but the easiest thing seemed to just skip this test on python 2.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13981: Upgrade tool: skip bad file test for Python 2.7
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13981:
URL: https://github.com/apache/airflow/pull/13981
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org