[jira] [Commented] (YARN-9235) If linux container executor is not set for a GPU cluster GpuResourceHandlerImpl is not initialized and NPE is thrown

["Adam Antal (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-9235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16787844#comment-16787844 ] 

Adam Antal commented on YARN-9235:
----------------------------------

It seems that the depending patches all got resolved, so this one can go in.

Could you please check the following items:
* Could you modify the log object name from {{LOGGER}} to {{LOG}}, as in this module most of those log objects are named that (see YARN-7047 to see that convention).
* Using {{(expected = YarnException.class)}} in {{testResourceHandlerNotInitialized}} is a good idea, but I'd rather be more precise on that, as YarnException is too general and it is possible this test still passes if any other YarnException is thrown - which is not the expected behaviour. Consider checking whether the cause of the exception contains/equals the new error message you provided in this patch.
* To take a step further you can make that error message a static package-private class variable with @VisibleForTesting annotation, and you can reference that from the test.
* Also probably a rebase is needed as those tests modified those files.

> If linux container executor is not set for a GPU cluster GpuResourceHandlerImpl is not initialized and NPE is thrown
> --------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-9235
>                 URL: https://issues.apache.org/jira/browse/YARN-9235
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: yarn
>    Affects Versions: 3.0.0, 3.1.0
>            Reporter: Antal Bálint Steinbach
>            Assignee: Antal Bálint Steinbach
>            Priority: Major
>         Attachments: YARN-9235.001.patch, YARN-9235.002.patch, YARN-9235.003.patch
>
>
> If GPU plugin is enabled for the NodeManager, it is possible to run jobs with GPU.
> However, if LinuxContainerExecutor is not configured, an NPE is thrown when calling 
> {code:java}
> GpuResourcePlugin.getNMResourceInfo{code}
> Also, there are no warns in the log if GPU is misconfigured like this. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org