You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/03 07:11:17 UTC
[GitHub] [flink] onyourhead opened a new pull request, #19628: [FLINK-27174][connector/kafka] Fix checking of bootstrapServers when already provided in producer Properties
onyourhead opened a new pull request, #19628:
URL: https://github.com/apache/flink/pull/19628
## What is the purpose of the change
Fix checking of bootstrapServers when already provided in producer Properties
## Brief change log
- *If the user provides bootstrapServers in the producer Properties, even if he does not use the setBootstrapServers method, the relevant check will no longer have a null exception*
- *The sanityCheck method is provided to put the checked code together*
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a diff in pull request #19628: [FLINK-27174][connector/kafka] Fix checking of bootstrapServers when already provided in producer Properties
Posted by GitBox <gi...@apache.org>.
fapaul commented on code in PR #19628:
URL: https://github.com/apache/flink/pull/19628#discussion_r874577453
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkBuilderTest.java:
##########
@@ -77,6 +77,15 @@ public void testPropertyHandling() {
assertEquals("v1", p.get("k1"));
assertEquals("correct", p.get("k2"));
});
+
+ Properties testConf1 = new Properties();
Review Comment:
It would be better to have a separate test case for this because it adds new functiontionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] onyourhead commented on pull request #19628: [FLINK-27174][connector/kafka] Fix checking of bootstrapServers when already provided in producer Properties
Posted by GitBox <gi...@apache.org>.
onyourhead commented on PR #19628:
URL: https://github.com/apache/flink/pull/19628#issuecomment-1119595202
Because there are some commits behind the master branch, the code of the backport is a little different. And `KafkaSinkBuilderTest` only exists in the master branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul merged pull request #19628: [FLINK-27174][connector/kafka] Fix checking of bootstrapServers when already provided in producer Properties
Posted by GitBox <gi...@apache.org>.
fapaul merged PR #19628:
URL: https://github.com/apache/flink/pull/19628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #19628: [FLINK-27174][connector/kafka] Fix checking of bootstrapServers when already provided in producer Properties
Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19628:
URL: https://github.com/apache/flink/pull/19628#issuecomment-1115803244
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1698cc20907bd91fb2f3f116276019cc7a3aaa09",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1698cc20907bd91fb2f3f116276019cc7a3aaa09",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1698cc20907bd91fb2f3f116276019cc7a3aaa09 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] onyourhead commented on pull request #19628: [FLINK-27174][connector/kafka] Fix checking of bootstrapServers when already provided in producer Properties
Posted by GitBox <gi...@apache.org>.
onyourhead commented on PR #19628:
URL: https://github.com/apache/flink/pull/19628#issuecomment-1129662170
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #19628: [FLINK-27174][connector/kafka] Fix checking of bootstrapServers when already provided in producer Properties
Posted by GitBox <gi...@apache.org>.
fapaul commented on PR #19628:
URL: https://github.com/apache/flink/pull/19628#issuecomment-1131290177
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] onyourhead commented on pull request #19628: [FLINK-27174][connector/kafka] Fix checking of bootstrapServers when already provided in producer Properties
Posted by GitBox <gi...@apache.org>.
onyourhead commented on PR #19628:
URL: https://github.com/apache/flink/pull/19628#issuecomment-1128589572
@fapaul Can you help review the code above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] onyourhead commented on a diff in pull request #19628: [FLINK-27174][connector/kafka] Fix checking of bootstrapServers when already provided in producer Properties
Posted by GitBox <gi...@apache.org>.
onyourhead commented on code in PR #19628:
URL: https://github.com/apache/flink/pull/19628#discussion_r875555542
##########
flink-connectors/flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkBuilderTest.java:
##########
@@ -77,6 +77,15 @@ public void testPropertyHandling() {
assertEquals("v1", p.get("k1"));
assertEquals("correct", p.get("k2"));
});
+
+ Properties testConf1 = new Properties();
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] onyourhead commented on pull request #19628: [FLINK-27174][connector/kafka] Fix checking of bootstrapServers when already provided in producer Properties
Posted by GitBox <gi...@apache.org>.
onyourhead commented on PR #19628:
URL: https://github.com/apache/flink/pull/19628#issuecomment-1129660837
> Please run `mvn spotless:apply` locally. Your current changes are not in line with our formatting guide lines.
Sorry, I'm not familiar with the process of participating in contributions. Now this problem has been fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org