You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by GitBox <gi...@apache.org> on 2020/11/27 13:00:08 UTC

[GitHub] [karaf] coheigea opened a new pull request #1259: KARAF-6925 - Initial attempt at supporting spring-security-crypto

coheigea opened a new pull request #1259:
URL: https://github.com/apache/karaf/pull/1259


   Some points to note:
    * In jaas/spring-security-crypto/pom.xml it just depends on a servicemix bundle, I wasn't sure whether to just depend on the normal spring jar here.
    * The feature I added could be reworked to remove dependency on a set version of Spring.
    * scrypt, bcrypt, pbkdf2 work well. For argon2, it is performing multiple encryptions, not sure why this is yet.
    * Remaining work: Update the default jaas file comments to show how to use it, and update the documentation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [karaf] coheigea commented on pull request #1259: KARAF-6925 - Initial attempt at supporting spring-security-crypto

Posted by GitBox <gi...@apache.org>.
coheigea commented on pull request #1259:
URL: https://github.com/apache/karaf/pull/1259#issuecomment-744254981


   Thanks @jbonofre, I was just making a trivial change to the logic.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [karaf] jbonofre commented on pull request #1259: KARAF-6925 - Initial attempt at supporting spring-security-crypto

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1259:
URL: https://github.com/apache/karaf/pull/1259#issuecomment-791880212


   As it's an optional JAAS bundle, it makes sense to keep it as a feature (no need to use private package as it's not part of "core" JAAS). LGTM.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [karaf] jbonofre commented on pull request #1259: KARAF-6925 - Initial attempt at supporting spring-security-crypto

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1259:
URL: https://github.com/apache/karaf/pull/1259#issuecomment-734825299


   I would use a different approach embedding spring-security as private to avoid feature dependency. Let me rework this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [karaf] jbonofre commented on pull request #1259: KARAF-6925 - Initial attempt at supporting spring-security-crypto

Posted by GitBox <gi...@apache.org>.
jbonofre commented on pull request #1259:
URL: https://github.com/apache/karaf/pull/1259#issuecomment-744253804


   As said, I will rework this one to avoid Spring bundles dependency and prefer spring-security embedded. I will do that tomorrow. Thanks !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [karaf] jbonofre merged pull request #1259: KARAF-6925 - Initial attempt at supporting spring-security-crypto

Posted by GitBox <gi...@apache.org>.
jbonofre merged pull request #1259:
URL: https://github.com/apache/karaf/pull/1259


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org