[GitHub] [helix] NealSun96 commented on a change in pull request #1009: Configurable thread pool size for AssignableInstance

[GitBox <gi...@apache.org>]

NealSun96 commented on a change in pull request #1009:
URL: https://github.com/apache/helix/pull/1009#discussion_r424758010



##########
File path: helix-core/src/main/java/org/apache/helix/task/assigner/AssignableInstance.java
##########
@@ -113,7 +113,7 @@ private void refreshTotalCapacity() {
     if (resourceCapacity == null) {
       resourceCapacity = new HashMap<>();
       resourceCapacity.put(LiveInstance.InstanceResourceType.TASK_EXEC_THREAD.name(),
-          Integer.toString(TaskConstants.DEFAULT_TASK_THREAD_POOL_SIZE));
+          Integer.toString(_liveInstance.getCurrentTaskThreadPoolSize()));

Review comment:
       There is a null check before _liveInstance assignment, see line 72. 

##########
File path: helix-core/src/test/java/org/apache/helix/task/assigner/TestAssignableInstance.java
##########
@@ -55,18 +55,20 @@ public void testInvalidInitialization() {
 
   @Test
   public void testInitializationWithQuotaUnset() {
+    int testCurrentTaskThreadPoolSize = 100;

Review comment:
       Sure.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org