You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2017/11/12 11:34:08 UTC
[GitHub] spark pull request #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSessi...
GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/19726
[SPARK-22490][DOC] Add PySpark doc for SparkSession.builder
## What changes were proposed in this pull request?
In PySpark API Document, [SparkSession.build](http://spark.apache.org/docs/2.2.0/api/python/pyspark.sql.html) is not documented and shows default value description.
```
SparkSession.builder = <pyspark.sql.session.Builder object ...
```
This PR adds the doc. The following is the diff of the generated result.
```
$ diff new.html old.html
95a96,101
> <dl class="attribute">
> <dt id="pyspark.sql.SparkSession.builder">
> <code class="descname">builder</code><a class="headerlink" href="#pyspark.sql.SparkSession.builder" title="Permalink to this definition">¶</a></dt>
> <dd><p>class variable for <a class="reference internal" href="#pyspark.sql.SparkSession.Builder" title="pyspark.sql.SparkSession.Builder"><code class="xref py py-class docutils literal"><span class="pre">Builder</span></code></a> shared by all <a class="reference internal" href="#pyspark.sql.SparkSession" title="pyspark.sql.SparkSession"><code class="xref py py-class docutils literal"><span class="pre">SparkSession</span></code></a> instances</p>
> </dd></dl>
>
212,216d217
< <dt id="pyspark.sql.SparkSession.builder">
< <code class="descname">builder</code><em class="property"> = <pyspark.sql.session.SparkSession.Builder object></em><a class="headerlink" href="#pyspark.sql.SparkSession.builder" title="Permalink to this definition">¶</a></dt>
< <dd></dd></dl>
<
< <dl class="attribute">
```
## How was this patch tested?
Manual.
```
cd python/docs
make html
open _build/html/pyspark.sql.html
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/spark SPARK-22490
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/19726.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #19726
----
commit fd93eac787470aef5387b570a3d6b809a637abf5
Author: Dongjoon Hyun <do...@apache.org>
Date: 2017-11-12T11:26:06Z
[SPARK-22490][DOC] Add PySpark doc for SparkSession.builder
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSessi...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19726#discussion_r150407573
--- Diff: python/docs/pyspark.sql.rst ---
@@ -7,6 +7,7 @@ Module Context
.. automodule:: pyspark.sql
:members:
:undoc-members:
+ :exclude-members: builder
--- End diff --
This blocks the default dummy doc for `builder`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSessi...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19726#discussion_r150429291
--- Diff: python/pyspark/sql/session.py ---
@@ -182,6 +185,7 @@ def getOrCreate(self):
session.sparkContext._conf.set(key, value)
return session
+ #: class variable for :class:`Builder` shared by all :class:`SparkSession` instances
--- End diff --
Sure.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19726
I see. Thank you, @HyukjinKwon .
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSessi...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19726#discussion_r150408083
--- Diff: python/pyspark/sql/session.py ---
@@ -182,6 +185,7 @@ def getOrCreate(self):
session.sparkContext._conf.set(key, value)
return session
+ #: class variable for :class:`Builder` shared by all :class:`SparkSession` instances
--- End diff --
I think we should rather stick to:
```
attr = 123
""" docstring """
```
assuming from https://stackoverflow.com/a/9558703. It sounds more closer to PEP8. AFAIK, `#:` is Sphinx specific syntax. The case above should also be recognisable in Sphinx as well.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19726
**[Test build #83757 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83757/testReport)** for PR 19726 at commit [`6f9fc84`](https://github.com/apache/spark/commit/6f9fc845697d898c4b481cf087c93bc005227a54).
* This patch **fails Python style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSessi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/19726
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19726
Thank you for review, @HyukjinKwon .
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19726
Thank you for review, @gatorsmile and @ueshin .
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19726
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83758/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19726
**[Test build #83739 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83739/testReport)** for PR 19726 at commit [`fd93eac`](https://github.com/apache/spark/commit/fd93eac787470aef5387b570a3d6b809a637abf5).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19726
**[Test build #83758 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83758/testReport)** for PR 19726 at commit [`b3090e7`](https://github.com/apache/spark/commit/b3090e77feb954681e79c29f5af68479da037053).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19726
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19726
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19726
**[Test build #83758 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83758/testReport)** for PR 19726 at commit [`b3090e7`](https://github.com/apache/spark/commit/b3090e77feb954681e79c29f5af68479da037053).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19726
LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSessi...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19726#discussion_r150429417
--- Diff: python/pyspark/sql/session.py ---
@@ -182,6 +185,7 @@ def getOrCreate(self):
session.sparkContext._conf.set(key, value)
return session
+ #: class variable for :class:`Builder` shared by all :class:`SparkSession` instances
--- End diff --
Yep.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19726
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83852/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSessi...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/19726#discussion_r150407580
--- Diff: python/pyspark/sql/session.py ---
@@ -72,6 +72,9 @@ class SparkSession(object):
... .appName("Word Count") \\
... .config("spark.some.config.option", "some-value") \\
... .getOrCreate()
+
+ .. autoattribute:: builder
--- End diff --
This adds a correct doc.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19726
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19726
cc @gatorsmile
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19726
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83757/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19726
Oh, I had to be clear, I think Sphinx 1.6.6 is in development and upgrading it is actually a bigger issue I think.
I tried other ways I could think ahead actually, but failed to figure out a better way. So, I meant LGTM assuming we should generally avoid this workaround but it's one exception (or possibly few in the future), and it is by a bug existing in Sphinx 1.6.6 <.
But let's wait for more feedback just in case I missed something and someone has a better idea.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19726
**[Test build #83757 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83757/testReport)** for PR 19726 at commit [`6f9fc84`](https://github.com/apache/spark/commit/6f9fc845697d898c4b481cf087c93bc005227a54).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19726
**[Test build #83852 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83852/testReport)** for PR 19726 at commit [`350edf4`](https://github.com/apache/spark/commit/350edf4826356b04f4344737581541b8eba600c0).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/19726
cc @holdenk too. This one is related with documenting attributes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSessi...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19726#discussion_r150408440
--- Diff: python/pyspark/sql/session.py ---
@@ -182,6 +185,7 @@ def getOrCreate(self):
session.sparkContext._conf.set(key, value)
return session
+ #: class variable for :class:`Builder` shared by all :class:`SparkSession` instances
--- End diff --
I think we should rather resemble:
https://github.com/apache/spark/blob/d6ee69e7761a62e47e21e4c2ce1bb20038d745b6/sql/core/src/main/scala/org/apache/spark/sql/SparkSession.scala#L970
and I'd use the term "class attribute" instead of "class variable"`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19726
**[Test build #83739 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83739/testReport)** for PR 19726 at commit [`fd93eac`](https://github.com/apache/spark/commit/fd93eac787470aef5387b570a3d6b809a637abf5).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19726
Thanks! Merged to master/2.2
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSessi...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/19726#discussion_r150408278
--- Diff: python/docs/pyspark.sql.rst ---
@@ -7,6 +7,7 @@ Module Context
.. automodule:: pyspark.sql
:members:
:undoc-members:
+ :exclude-members: builder
--- End diff --
I believe this is a bug in Sphinx. I think it should automatically detect the attribute docstring. I recently took a look before:
- `https://github.com/sphinx-doc/sphinx/pull/2299`
- `https://github.com/sphinx-doc/sphinx/issues/2298`
I haven't tested the fix by myself but I believe this will be fixed in Sphinx 1.6.6.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by ueshin <gi...@git.apache.org>.
Github user ueshin commented on the issue:
https://github.com/apache/spark/pull/19726
LGTM for now, but I'd like you to add some comments to explain this is a workaround for Sphinx <`1.6.6`.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/19726
**[Test build #83852 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/83852/testReport)** for PR 19726 at commit [`350edf4`](https://github.com/apache/spark/commit/350edf4826356b04f4344737581541b8eba600c0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19726
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19726
@HyukjinKwon . For upgrading `sphinx` version, we can upgrade the minimal version from [1.2](https://github.com/apache/spark/blob/master/python/docs/conf.py#L26) to 1.6.6. We had better upgrade in another issue because we may need to consider Jenkins worker environments. Or, is it safe if I do that here?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/19726
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/83739/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/19726
cc @ueshin
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #19726: [SPARK-22490][DOC] Add PySpark doc for SparkSession.buil...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/19726
Thank you, @HyukjinKwon, @ueshin , @gatorsmile .
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org