You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bo...@apache.org on 2017/09/28 10:50:08 UTC

[3/5] ant git commit: Fix zip-test

Fix zip-test


Project: http://git-wip-us.apache.org/repos/asf/ant/repo
Commit: http://git-wip-us.apache.org/repos/asf/ant/commit/2c5430b4
Tree: http://git-wip-us.apache.org/repos/asf/ant/tree/2c5430b4
Diff: http://git-wip-us.apache.org/repos/asf/ant/diff/2c5430b4

Branch: refs/heads/master
Commit: 2c5430b420890ac5ac68794f95c2ac83e5a27456
Parents: a0cb1fa
Author: George Bateman <ge...@gmail.com>
Authored: Tue Sep 26 22:43:28 2017 +0100
Committer: Stefan Bodewig <bo...@apache.org>
Committed: Thu Sep 28 12:43:39 2017 +0200

----------------------------------------------------------------------
 src/tests/antunit/taskdefs/zip-test.xml | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ant/blob/2c5430b4/src/tests/antunit/taskdefs/zip-test.xml
----------------------------------------------------------------------
diff --git a/src/tests/antunit/taskdefs/zip-test.xml b/src/tests/antunit/taskdefs/zip-test.xml
index c2dfbe3..7ff45c1 100644
--- a/src/tests/antunit/taskdefs/zip-test.xml
+++ b/src/tests/antunit/taskdefs/zip-test.xml
@@ -185,19 +185,19 @@
 
     <target name="testSetZipModTime">
       <mkdir dir="${input}/"/>
+      <mkdir dir="${input}/subdir"/>
       <touch file="${input}/test1.txt"/>
+      <touch file="${input}/subdir/test2.txt"/>
       <mkdir dir="${output}"/>
-      <zip destfile="${output}/test.zip" basedir="${input}" modificationtime="2016-01-01 00:00">
-        <fileset dir="${input}"/>
-      </zip>
+      <zip destfile="${output}/test.zip" basedir="${input}" modificationtime="2016-01-01 00:00" />
       <checksum file="${output}/test.zip" property="testSetZipModTime_hash" />
       <delete file="${output}/test.zip" />
 
+      <sleep seconds="4" /> <!-- Necessary to ensure zips would have normally differed in timestamp -->
       <touch file="${input}/test1.txt"/>
-      <zip destfile="${output}/test.zip" basedir="${input}" modificationtime="2016-01-01 00:00">
-        <fileset dir="${input}"/>
-      </zip>
-      <checksum file="${output}/test.zip" property="testSetZipModTime_hash" verifyproperty="testSetZipModTime_okay" />
+      <touch file="${input}/subdir/test2.txt"/>
+      <zip destfile="${output}/test.zip" basedir="${input}" modificationtime="2016-01-01 00:00" />
+      <checksum file="${output}/test.zip" property="${testSetZipModTime_hash}" verifyproperty="testSetZipModTime_okay" />
       <au:assertTrue>
         <equals arg1="${testSetZipModTime_okay}" arg2="true" />
       </au:assertTrue>