[jira] [Commented] (FLINK-10301) Allow a custom Configuration in StreamNetworkBenchmarkEnvironment

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607016#comment-16607016 ] 

ASF GitHub Bot commented on FLINK-10301:
----------------------------------------

NicoK opened a new pull request #6670: [FLINK-10301][network] extend StreamNetworkBenchmarkEnvironment to allow custom Configuration instances
URL: https://github.com/apache/flink/pull/6670
 
 
   ## What is the purpose of the change
   
   `StreamNetworkBenchmarkEnvironment` currently instantiates its `NettyConfig` with `new Configuration()` but for testing and benchmarking with different options, it would be nice to allow the user to provide a custom instance instead.
   
   ## Brief change log
   
   - extend `StreamNetworkBenchmarkEnvironment#createNettyNetworkEnvironment` and related methods with a `Configuration` parameter
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as `StreamNetworkPointToPointBenchmarkTest` and `StreamNetworkThroughputBenchmarkTest`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Allow a custom Configuration in StreamNetworkBenchmarkEnvironment
> -----------------------------------------------------------------
>
>                 Key: FLINK-10301
>                 URL: https://issues.apache.org/jira/browse/FLINK-10301
>             Project: Flink
>          Issue Type: Improvement
>          Components: Network, Tests
>    Affects Versions: 1.7.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Major
>              Labels: pull-request-available
>
> {{StreamNetworkBenchmarkEnvironment}} currently instantiates its {{NettyConfig}} with {{new Configuration()}} but for testing with different options, it would be nice to allow the user to provide a custom instance instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)