You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/07/19 10:52:07 UTC
Review Request 23709: Fix line comments end punctuation in libprocess
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23709/
-----------------------------------------------------------
Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.
Repository: mesos-git
Description
-------
Fix line comments end punctuation in libprocess
Diffs
-----
3rdparty/libprocess/include/process/check.hpp 107446ac3e62c6ee91ffe7508ca337089ce1117a
3rdparty/libprocess/include/process/http.hpp 6358e331ae1256b19d52a6803875d2b64d75eb69
3rdparty/libprocess/include/process/protobuf.hpp a232107389d8506aaa5ac0d89e646e08f4fe1b3a
3rdparty/libprocess/include/process/sequence.hpp 241afd243c3a91a824186b2dc511e9384901799f
3rdparty/libprocess/include/process/system.hpp 48a02f0b0ebbf45331506e53a78a10f02c6fde44
Diff: https://reviews.apache.org/r/23709/diff/
Testing
-------
make check
Thanks,
Timothy Chen
Re: Review Request 23709: Fix line comments end punctuation in libprocess
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23709/#review49332
-----------------------------------------------------------
Ship it!
LGTM
3rdparty/libprocess/include/process/http.hpp
<https://reviews.apache.org/r/23709/#comment86326>
The parentheses here feel weird, since this is talking about iterating through a string, finding a '%' character, then verifying the next two characters are HEXDIG. I would actually feel more comfortable with a period here, or wrap the entire "% HEXDIG HEXDIG" in quotes or parentheses/brackets.
- Adam B
On July 19, 2014, 1:52 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23709/
> -----------------------------------------------------------
>
> (Updated July 19, 2014, 1:52 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fix line comments end punctuation in libprocess
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/check.hpp 107446ac3e62c6ee91ffe7508ca337089ce1117a
> 3rdparty/libprocess/include/process/http.hpp 6358e331ae1256b19d52a6803875d2b64d75eb69
> 3rdparty/libprocess/include/process/protobuf.hpp a232107389d8506aaa5ac0d89e646e08f4fe1b3a
> 3rdparty/libprocess/include/process/sequence.hpp 241afd243c3a91a824186b2dc511e9384901799f
> 3rdparty/libprocess/include/process/system.hpp 48a02f0b0ebbf45331506e53a78a10f02c6fde44
>
> Diff: https://reviews.apache.org/r/23709/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 23709: Fix line comments end punctuation in libprocess
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23709/#review48773
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On July 19, 2014, 1:52 a.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23709/
> -----------------------------------------------------------
>
> (Updated July 19, 2014, 1:52 a.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Fix line comments end punctuation in libprocess
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/check.hpp 107446ac3e62c6ee91ffe7508ca337089ce1117a
> 3rdparty/libprocess/include/process/http.hpp 6358e331ae1256b19d52a6803875d2b64d75eb69
> 3rdparty/libprocess/include/process/protobuf.hpp a232107389d8506aaa5ac0d89e646e08f4fe1b3a
> 3rdparty/libprocess/include/process/sequence.hpp 241afd243c3a91a824186b2dc511e9384901799f
> 3rdparty/libprocess/include/process/system.hpp 48a02f0b0ebbf45331506e53a78a10f02c6fde44
>
> Diff: https://reviews.apache.org/r/23709/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 23709: Fix line comments end punctuation in
libprocess
Posted by Adam B <ad...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23709/#review51380
-----------------------------------------------------------
Ship it!
Ship It!
- Adam B
On Aug. 19, 2014, 5:36 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23709/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2014, 5:36 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Review: https://reviews.apache.org/r/23709
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/check.hpp 107446ac3e62c6ee91ffe7508ca337089ce1117a
> 3rdparty/libprocess/include/process/http.hpp 6358e331ae1256b19d52a6803875d2b64d75eb69
> 3rdparty/libprocess/include/process/protobuf.hpp f3190f651deb8f6d0f011d9ace5098df578b2a3d
> 3rdparty/libprocess/include/process/sequence.hpp 241afd243c3a91a824186b2dc511e9384901799f
> 3rdparty/libprocess/include/process/system.hpp 48a02f0b0ebbf45331506e53a78a10f02c6fde44
>
> Diff: https://reviews.apache.org/r/23709/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 23709: Fix line comments end punctuation in
libprocess
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23709/
-----------------------------------------------------------
(Updated Aug. 20, 2014, 12:36 a.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Niklas Nielsen.
Repository: mesos-git
Description (updated)
-------
Review: https://reviews.apache.org/r/23709
Diffs (updated)
-----
3rdparty/libprocess/include/process/check.hpp 107446ac3e62c6ee91ffe7508ca337089ce1117a
3rdparty/libprocess/include/process/http.hpp 6358e331ae1256b19d52a6803875d2b64d75eb69
3rdparty/libprocess/include/process/protobuf.hpp f3190f651deb8f6d0f011d9ace5098df578b2a3d
3rdparty/libprocess/include/process/sequence.hpp 241afd243c3a91a824186b2dc511e9384901799f
3rdparty/libprocess/include/process/system.hpp 48a02f0b0ebbf45331506e53a78a10f02c6fde44
Diff: https://reviews.apache.org/r/23709/diff/
Testing
-------
make check
Thanks,
Timothy Chen