[jira] [Commented] (LOG4NET-405) SmtpAppender encoding changes

["Dominik Psenner (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LOG4NET-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13821025#comment-13821025 ] 

Dominik Psenner commented on LOG4NET-405:
-----------------------------------------

You're right. According to http://msdn.microsoft.com/en-us/library/system.text.encoding.default(v=vs.110).aspx Encoding.UTF8 might be a better default encoding. I'm changing that right away and voting now that it should be shipped along with 1.2.13.

> SmtpAppender encoding changes
> -----------------------------
>
>                 Key: LOG4NET-405
>                 URL: https://issues.apache.org/jira/browse/LOG4NET-405
>             Project: Log4net
>          Issue Type: Bug
>          Components: Appenders
>    Affects Versions: 1.2.12
>         Environment: Windows 7, net 4
>            Reporter: Roman Kvasov
>             Fix For: 1.2.13
>
>
> After update to log4net 1.2.12 email encoding changed and my mail client
> fail to render unicode symbols.
> I think changes made for issue https://issues.apache.org/jira/browse/LOG4NET-354 brake encoding in SmtpAppender
> log4net 1.2.10 use utf-8 encoding by default, below headers from email
> Content-Type: text/plain; charset=utf-8
> Content-Transfer-Encoding: base64
> after update on log4net 1.2.12 email encoding koi8-r
> Content-Type: text/plain; charset=koi8-r
> Content-Transfer-Encoding: quoted-printable
> I think change default encoding from utf-8 is pretty strange.
> Proposed fix:
> Do not use Encoding.Default, let SubjectEncoding and BodyEncoding by default be null, on email send set encoding only if field not null.



--
This message was sent by Atlassian JIRA
(v6.1#6144)