You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2022/10/25 07:34:55 UTC
[GitHub] [ratis-hadoop-projects] lhotari opened a new pull request, #4: Upgrade ratis to 2.4.0
lhotari opened a new pull request, #4:
URL: https://github.com/apache/ratis-hadoop-projects/pull/4
## What changes were proposed in this pull request?
Upgrade ratis to 2.4.0
## How was this patch tested?
`mvn test`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-hadoop-projects] lhotari commented on pull request #4: RATIS-1738. Upgrade ratis to 2.4.0
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #4:
URL: https://github.com/apache/ratis-hadoop-projects/pull/4#issuecomment-1309325848
> @lhotari , there are still build failures. Since we are going to release 2.4.1 soon, how about we wait for it?
@szetszwo Yes that makes sense. This PR isn't urgent. I haven't yet investigated the problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-hadoop-projects] szetszwo commented on pull request #4: Upgrade ratis to 2.4.0
Posted by GitBox <gi...@apache.org>.
szetszwo commented on PR #4:
URL: https://github.com/apache/ratis-hadoop-projects/pull/4#issuecomment-1302995401
@lhotari , could you file JIRA for this? I like to post some patch file to explain this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-hadoop-projects] szetszwo commented on pull request #4: RATIS-1738. Upgrade ratis to 2.4.0
Posted by GitBox <gi...@apache.org>.
szetszwo commented on PR #4:
URL: https://github.com/apache/ratis-hadoop-projects/pull/4#issuecomment-1309264300
@lhotari , there are still build failures. Since we are going to release 2.4.1 soon, how about we wait for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-hadoop-projects] lhotari commented on pull request #4: Upgrade ratis to 2.4.0
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #4:
URL: https://github.com/apache/ratis-hadoop-projects/pull/4#issuecomment-1303020902
> @lhotari , could you file JIRA for this? I like to post some patch file to explain this.
@szetszwo I created https://issues.apache.org/jira/browse/RATIS-1738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-hadoop-projects] lhotari commented on pull request #4: Upgrade ratis to 2.4.0
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #4:
URL: https://github.com/apache/ratis-hadoop-projects/pull/4#issuecomment-1299837209
This is the compilation error:
```
Error: COMPILATION ERROR :
[INFO] -------------------------------------------------------------
Error: /home/runner/work/ratis-hadoop-projects/ratis-hadoop-projects/ratis-hadoop/src/main/java/org/apache/ratis/hadooprpc/client/CombinedClientProtocolClientSideTranslatorPB.java:[52,7] error: CombinedClientProtocolClientSideTranslatorPB is not abstract and does not override abstract method leaderElectionManagement(LeaderElectionManagementRequest) in AdminProtocol
```
I experimented by adding a dummy method to get past that error and there are more. @szetszwo do you know if someone else could help to fix the migration to 2.4.0 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-hadoop-projects] lhotari commented on pull request #4: Upgrade ratis to 2.4.0
Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #4:
URL: https://github.com/apache/ratis-hadoop-projects/pull/4#issuecomment-1299814298
> @lhotari , thanks a lot for working on this! What is your goal for updating the pom parent version? If the goal is to update ratis-hadoop-projects with current Ratis 2.4.0 release, we should update the versions of the dependencies/maven plugins as well.
I missed updating `ratis.version`. Now that it's updated, it can be seen that ratis-hadoop is not compatible with Ratis 2.4.0 .
My goal would be to have the LogService example be kept up-to-date. I started a thread https://lists.apache.org/thread/sloz0d18fzq1n2jqsx1mkyo4z6ovkh9r on the mailing list about questioning the move of LogService out of Ratis core repository. The LogService would be a valuable example of using Ratis and I guess we should drop the Hadoop dependency completely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ratis-hadoop-projects] szetszwo commented on pull request #4: Upgrade ratis to 2.4.0
Posted by GitBox <gi...@apache.org>.
szetszwo commented on PR #4:
URL: https://github.com/apache/ratis-hadoop-projects/pull/4#issuecomment-1291726194
@lhotari , thanks a lot for working on this! What is your goal for updating the pom parent version? If the goal is to update ratis-hadoop-projects with current Ratis 2.4.0 release, we should update the versions of the dependencies/maven plugins as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org