You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by ambud <gi...@git.apache.org> on 2017/02/04 21:33:02 UTC
[GitHub] storm pull request #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI
GitHub user ambud opened a pull request:
https://github.com/apache/storm/pull/1922
STORM-2344 Flux YAML File Viewer for Nimbus UI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ambud/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1922.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1922
----
commit e73369be9979b88ce1446d3f6574a8f5177996e9
Author: ambud <as...@gmail.com>
Date: 2017-02-04T21:32:16Z
STORM-2344 Adding Flux File Viewer to Nimbus UI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI
Posted by ambud <gi...@git.apache.org>.
Github user ambud commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99747044
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+<html>
--- End diff --
Sorry I misunderstood. @HeartSaVioR not sure what location in the homepage do we want to put the forward link?
One option could be to skip the link in homepage and provide it via Ambari View.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI
Posted by ambud <gi...@git.apache.org>.
Github user ambud commented on the issue:
https://github.com/apache/storm/pull/1922
- Added license
- Squashed commits.
Couldn't find a min.js for dagre
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99760485
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+<html>
--- End diff --
No it shouldn't be only for Ambari. I'll see where's good location to put. Welcome any ideas.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI
Posted by ambud <gi...@git.apache.org>.
Github user ambud commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99961278
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+<html>
--- End diff --
Added a link on the top right hand side after the username place holder. Here's the icon:
[Icon](https://github.com/ambud/storm/blob/af8ed339cb3896100dabe3619c0fba2d19165dff/storm-core/src/ui/public/images/flux.png)
Y for YAML and also for Flux Capacitor from Back to the future \U0001f4af
Please let me know if this works.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI
Posted by ambud <gi...@git.apache.org>.
Github user ambud commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99719977
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+<html>
--- End diff --
@vesense I thought someone will ask for that :D
Just added both.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1922
And some javascript files like esprima.js are not minimized. Is there any reason not to do?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99745970
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+<html>
--- End diff --
I think @vesense means that Storm UI index page should have a link to go to flux page. You're adding reverse link, which is already missing.
And I think we might want to port back to 1.x but not necessary to 1.0.x. Let's keep the bugfix version line.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99760968
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+<html>
--- End diff --
If we can have icon then we can place it to the left side of the upper right magnifier icon. If we can't, Text link `[Flux Viewer]` or so may be fine given that we can replace it anytime if we find better alternatives.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1922
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1922
js files are licensed under BSD-2 and MIT, seems OK.
Regarding min.js, I think you're saying about cytoscape-dagre.js, which is under 200 lines so it would be OK.
+1 from me. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1922
@ambud
We need to update LICENSE file to reflect newly added js files.
https://github.com/apache/storm/blob/master/LICENSE
Could you update it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99510863
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+<html>
--- End diff --
Missing apache license. And I guess we may need a link from storm ui homepage to flux.html.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI
Posted by ambud <gi...@git.apache.org>.
Github user ambud commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99745686
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+<html>
--- End diff --
Also, should we plan on back porting this to 0.10.x and 1.x?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI
Posted by ambud <gi...@git.apache.org>.
Github user ambud commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99966356
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+<html>
--- End diff --
<img width="1280" alt="storm-ui" src="https://cloud.githubusercontent.com/assets/9707358/22717941/75767376-ed63-11e6-849e-1201bf6479ca.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI
Posted by vesense <gi...@git.apache.org>.
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99776407
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+<html>
--- End diff --
I have the same idea as @HeartSaVioR :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99964052
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+<html>
--- End diff --
And posting screenshot to the comment would help us to see.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1922: STORM-2344 Flux YAML File Viewer for Nimbus UI
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1922#discussion_r99963942
--- Diff: storm-core/src/ui/public/flux.html ---
@@ -0,0 +1,139 @@
+<html>
--- End diff --
Not sure which is better between F (for Flux) and Y (for Yaml). I guess the question could be changed to is flux yaml viewer **flux** yaml viewer, or flux **yaml** viewer. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---