[jira] [Commented] (LUCENE-10002) Remove IndexSearcher#search(Query,Collector) in favor of IndexSearcher#search(Query,CollectorManager)

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-10002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486566#comment-17486566 ] 

ASF subversion and git services commented on LUCENE-10002:
----------------------------------------------------------

Commit ee7a8d6918717e41e77afcde2c898655daa2173a in lucene's branch refs/heads/main from Luca Cavanna
[ https://gitbox.apache.org/repos/asf?p=lucene.git;h=ee7a8d6 ]

LUCENE-10002: Replace some IndexSearcher#search(Collector, Query) in tests (#639)

Also use LuceneTestCase#newSearcher

> Remove IndexSearcher#search(Query,Collector) in favor of IndexSearcher#search(Query,CollectorManager)
> -----------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-10002
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10002
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Priority: Minor
>          Time Spent: 13h
>  Remaining Estimate: 0h
>
> It's a bit trappy that you can create an IndexSearcher with an executor, but that it would always search on the caller thread when calling {{IndexSearcher#search(Query,Collector)}}.
>  Let's remove {{IndexSearcher#search(Query,Collector)}}, point our users to {{IndexSearcher#search(Query,CollectorManager)}} instead, and change factory methods of our main collectors (e.g. {{TopScoreDocCollector#create}}) to return a {{CollectorManager}} instead of a {{Collector}}?



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org