You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@roller.apache.org by Elias Torres <el...@torrez.us> on 2006/02/02 07:00:51 UTC
Tagging has arrived!
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Folks,
I just wanted to let you know that the much awaited *preliminary*
tagging support in Roller (from IBM) has been checked in the tagging
branch Dave created.
Changes consist of the following:
- - Added new table to createdb.vm to store tagging information
- - Created new pojo and query results wrapper
- - Modified the WeblogManager interface to support tags
- - Implemented WeblogManager using a HibernateStrategy
- - Modified WeblogEditEntry Form to enter tags
- - Added new sidebar, tagcloud, etc to Main Page
I want to take the opportunity to give credit to Phay Tac Lau (currently
an IBM intern), who did most of the original development for this
feature for our upcoming internal blogging release based on Roller 2.0.
Let the discussion/development begin!
- -Elias
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFD4aATtsNTCOFcV0oRAixgAJ9EF7dA0FkL/VNBqnTlS2V2iGJCMQCeJJy7
66uBhPNcDlr9RjcFo2osvDY=
=C8hd
-----END PGP SIGNATURE-----
code conventions? [was: Re: Tagging has arrived!]
Posted by Jeff Blattman <Je...@Sun.COM>.
where are the conventions defined? i missed that i guess.
David M Johnson wrote:
> - The code is good and follows our conventions
>
Re: Tagging has arrived!
Posted by Elias Torres <el...@torrez.us>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
David M Johnson wrote:
>
>>> On Feb 2, 2006, at 1:00 AM, Elias Torres wrote:
>>>
>>>> I just wanted to let you know that the much awaited *preliminary*
>>>> tagging support in Roller (from IBM) has been checked in the tagging
>>>> branch Dave created.
>>>>
>>>> Changes consist of the following:
>>>>
>>>> - - Added new table to createdb.vm to store tagging information
>>>> - - Created new pojo and query results wrapper
>>>> - - Modified the WeblogManager interface to support tags
>>>> - - Implemented WeblogManager using a HibernateStrategy
>>>> - - Modified WeblogEditEntry Form to enter tags
>>>> - - Added new sidebar, tagcloud, etc to Main Page
>>>>
>>>> I want to take the opportunity to give credit to Phay Tac Lau
>>>> (currently
>>>> an IBM intern), who did most of the original development for this
>>>> feature for our upcoming internal blogging release based on Roller
>>>> 2.0.
>>>>
>>>> Let the discussion/development begin!
>
>
>
> OK, I've got this up and running. Some quick first impressions...
>
> - The code is good and follows our conventions
Thanks.
>
> - Changes are isolated and don't change existing queries
There's one query that worked in DB2 and did not work on MySQL. We need
to look at this in more detail.
>
> - No new newsfeeds are added
We should add feeds. I believe we have some velocity templates hooked
up, I just didn't check those in yet.
>
> - The new Tag Query (tags.do) page could use some work. It should
> probably be a tab rather than status bar choice up there with the Main
> Menu link.
>
I agree. I just added it last minute so you can get access to it.
>
> On first glance, I don't see any reason this shouldn't go into trunk.
> Are we happy with the data model?
Well. We are ok with it, but it doesn't reflect all of the changes that
David Levy had suggested. I'm open to any of his suggestions and I
tried, but I was getting some error with the new columns.
However, if it goes into the trunk, we'll have to worry less about
merging changes. I'm also missing tag display in the admin interface.
>
> - Dave
>
>
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFD4k0ltsNTCOFcV0oRAjZmAJ9mLkQhSwCl6sRHBTHRVZK8Z4iajgCePUv+
65XVzyoqkSqYqYqtB5WddVA=
=Gz4v
-----END PGP SIGNATURE-----
Re: Tagging has arrived!
Posted by David M Johnson <Da...@Sun.COM>.
On Feb 2, 2006, at 2:33 PM, Allen Gilliland wrote:
> On Thu, 2006-02-02 at 09:58, David M Johnson wrote:
>> On first glance, I don't see any reason this shouldn't go into trunk.
>> Are we happy with the data model?
>
> whoa, whoa, whoa! I haven't had a chance to look at this yet, but
> please don't rush this into the trunk. I'm not sure if your
> comment was really meant to suggest that you felt it was ready for
> the trunk, but I just want to be clear.
I was just trying to get the conversation going. I'm not going to
commit anything to trunk until we're all happy with the contribution.
- Dave
Re: Tagging has arrived!
Posted by Matt Raible <mr...@gmail.com>.
Nope. I haven't had a chance. Perhaps a hosted demo is in order? Or
a screencast?
On 3/2/06, David M Johnson <Da...@sun.com> wrote:
> Anybody had a chance to evaluate Elias' tagging work?
> It's been a month now since Elias submitted the work.
>
> - Dave
>
>
>
> On Feb 9, 2006, at 12:50 PM, Allen Gilliland wrote:
> > Unfortunately, no, I haven't had time.
> >
> > I've been pulled off of all my normal blogs/Roller duties to handle
> > an unrelated urgent issue. Hopefully I'll have time to look at it
> > next week.
> >
> > AFAIK Roller 2.1 still hasn't been released, so I don't think this
> > is at risk for 2.2 yet.
> >
> > -- Allen
> >
> >
> > On Thu, 2006-02-09 at 06:17, Elias Torres wrote:
> >> -----BEGIN PGP SIGNED MESSAGE-----
> >> Hash: SHA1
> >>
> >> Allen,
> >>
> >> Have you had a chance to look at the tagging code? I want to know
> >> what
> >> the next steps are. We should have more discussion on the subject
> >> if we
> >> want to do this with 2.2.
> >>
> >> - -Elias
> >>
> >> Allen Gilliland wrote:
> >>> On Thu, 2006-02-02 at 09:58, David M Johnson wrote:
> >>>
> >>>> On first glance, I don't see any reason this shouldn't go into
> >>>> trunk.
> >>>> Are we happy with the data model?
> >>>
> >>>
> >>> whoa, whoa, whoa! I haven't had a chance to look at this yet,
> >>> but please don't rush this into the trunk. I'm not sure if your
> >>> comment was really meant to suggest that you felt it was ready
> >>> for the trunk, but I just want to be clear.
> >>>
> >>> -- Allen
> >>>
> >>>
> >>>
> >>>> - Dave
> >>>>
> >>>>
> >>>
> >>>
> >>>
> >> -----BEGIN PGP SIGNATURE-----
> >> Version: GnuPG v1.4.1 (GNU/Linux)
> >>
> >> iD8DBQFD6075tsNTCOFcV0oRAvGbAJ9nWj7QXiNlCR+OLFw5gQylFczQjwCfbY/S
> >> yBpXEaT9MFm9GnHRAN5v19s=
> >> =9jrZ
> >> -----END PGP SIGNATURE-----
>
>
Re: Tagging has arrived!
Posted by David M Johnson <Da...@Sun.COM>.
Anybody had a chance to evaluate Elias' tagging work?
It's been a month now since Elias submitted the work.
- Dave
On Feb 9, 2006, at 12:50 PM, Allen Gilliland wrote:
> Unfortunately, no, I haven't had time.
>
> I've been pulled off of all my normal blogs/Roller duties to handle
> an unrelated urgent issue. Hopefully I'll have time to look at it
> next week.
>
> AFAIK Roller 2.1 still hasn't been released, so I don't think this
> is at risk for 2.2 yet.
>
> -- Allen
>
>
> On Thu, 2006-02-09 at 06:17, Elias Torres wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Allen,
>>
>> Have you had a chance to look at the tagging code? I want to know
>> what
>> the next steps are. We should have more discussion on the subject
>> if we
>> want to do this with 2.2.
>>
>> - -Elias
>>
>> Allen Gilliland wrote:
>>> On Thu, 2006-02-02 at 09:58, David M Johnson wrote:
>>>
>>>> On first glance, I don't see any reason this shouldn't go into
>>>> trunk.
>>>> Are we happy with the data model?
>>>
>>>
>>> whoa, whoa, whoa! I haven't had a chance to look at this yet,
>>> but please don't rush this into the trunk. I'm not sure if your
>>> comment was really meant to suggest that you felt it was ready
>>> for the trunk, but I just want to be clear.
>>>
>>> -- Allen
>>>
>>>
>>>
>>>> - Dave
>>>>
>>>>
>>>
>>>
>>>
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1.4.1 (GNU/Linux)
>>
>> iD8DBQFD6075tsNTCOFcV0oRAvGbAJ9nWj7QXiNlCR+OLFw5gQylFczQjwCfbY/S
>> yBpXEaT9MFm9GnHRAN5v19s=
>> =9jrZ
>> -----END PGP SIGNATURE-----
Re: Tagging has arrived!
Posted by Allen Gilliland <Al...@Sun.COM>.
Unfortunately, no, I haven't had time.
I've been pulled off of all my normal blogs/Roller duties to handle an unrelated urgent issue. Hopefully I'll have time to look at it next week.
AFAIK Roller 2.1 still hasn't been released, so I don't think this is at risk for 2.2 yet.
-- Allen
On Thu, 2006-02-09 at 06:17, Elias Torres wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Allen,
>
> Have you had a chance to look at the tagging code? I want to know what
> the next steps are. We should have more discussion on the subject if we
> want to do this with 2.2.
>
> - -Elias
>
> Allen Gilliland wrote:
> > On Thu, 2006-02-02 at 09:58, David M Johnson wrote:
> >
> >>On first glance, I don't see any reason this shouldn't go into trunk.
> >>Are we happy with the data model?
> >
> >
> > whoa, whoa, whoa! I haven't had a chance to look at this yet, but please don't rush this into the trunk. I'm not sure if your comment was really meant to suggest that you felt it was ready for the trunk, but I just want to be clear.
> >
> > -- Allen
> >
> >
> >
> >>- Dave
> >>
> >>
> >
> >
> >
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.1 (GNU/Linux)
>
> iD8DBQFD6075tsNTCOFcV0oRAvGbAJ9nWj7QXiNlCR+OLFw5gQylFczQjwCfbY/S
> yBpXEaT9MFm9GnHRAN5v19s=
> =9jrZ
> -----END PGP SIGNATURE-----
Re: Tagging has arrived!
Posted by Elias Torres <el...@torrez.us>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Allen,
Have you had a chance to look at the tagging code? I want to know what
the next steps are. We should have more discussion on the subject if we
want to do this with 2.2.
- -Elias
Allen Gilliland wrote:
> On Thu, 2006-02-02 at 09:58, David M Johnson wrote:
>
>>On first glance, I don't see any reason this shouldn't go into trunk.
>>Are we happy with the data model?
>
>
> whoa, whoa, whoa! I haven't had a chance to look at this yet, but please don't rush this into the trunk. I'm not sure if your comment was really meant to suggest that you felt it was ready for the trunk, but I just want to be clear.
>
> -- Allen
>
>
>
>>- Dave
>>
>>
>
>
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFD6075tsNTCOFcV0oRAvGbAJ9nWj7QXiNlCR+OLFw5gQylFczQjwCfbY/S
yBpXEaT9MFm9GnHRAN5v19s=
=9jrZ
-----END PGP SIGNATURE-----
Re: Tagging has arrived!
Posted by Allen Gilliland <Al...@Sun.COM>.
On Thu, 2006-02-02 at 09:58, David M Johnson wrote:
>
> On first glance, I don't see any reason this shouldn't go into trunk.
> Are we happy with the data model?
whoa, whoa, whoa! I haven't had a chance to look at this yet, but please don't rush this into the trunk. I'm not sure if your comment was really meant to suggest that you felt it was ready for the trunk, but I just want to be clear.
-- Allen
>
> - Dave
>
>
Re: Tagging has arrived!
Posted by David M Johnson <Da...@Sun.COM>.
>> On Feb 2, 2006, at 1:00 AM, Elias Torres wrote:
>>> I just wanted to let you know that the much awaited *preliminary*
>>> tagging support in Roller (from IBM) has been checked in the tagging
>>> branch Dave created.
>>>
>>> Changes consist of the following:
>>>
>>> - - Added new table to createdb.vm to store tagging information
>>> - - Created new pojo and query results wrapper
>>> - - Modified the WeblogManager interface to support tags
>>> - - Implemented WeblogManager using a HibernateStrategy
>>> - - Modified WeblogEditEntry Form to enter tags
>>> - - Added new sidebar, tagcloud, etc to Main Page
>>>
>>> I want to take the opportunity to give credit to Phay Tac Lau
>>> (currently
>>> an IBM intern), who did most of the original development for this
>>> feature for our upcoming internal blogging release based on
>>> Roller 2.0.
>>>
>>> Let the discussion/development begin!
OK, I've got this up and running. Some quick first impressions...
- The code is good and follows our conventions
- Changes are isolated and don't change existing queries
- No new newsfeeds are added
- The new Tag Query (tags.do) page could use some work. It should
probably be a tab rather than status bar choice up there with the
Main Menu link.
On first glance, I don't see any reason this shouldn't go into trunk.
Are we happy with the data model?
- Dave
Re: Tagging has arrived!
Posted by Elias Torres <el...@torrez.us>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
David M Johnson wrote:
>
> On Feb 2, 2006, at 1:00 AM, Elias Torres wrote:
>
>> I just wanted to let you know that the much awaited *preliminary*
>> tagging support in Roller (from IBM) has been checked in the tagging
>> branch Dave created.
>>
>> Changes consist of the following:
>>
>> - - Added new table to createdb.vm to store tagging information
>> - - Created new pojo and query results wrapper
>> - - Modified the WeblogManager interface to support tags
>> - - Implemented WeblogManager using a HibernateStrategy
>> - - Modified WeblogEditEntry Form to enter tags
>> - - Added new sidebar, tagcloud, etc to Main Page
>>
>> I want to take the opportunity to give credit to Phay Tac Lau (currently
>> an IBM intern), who did most of the original development for this
>> feature for our upcoming internal blogging release based on Roller 2.0.
>>
>> Let the discussion/development begin!
>
>
> Thanks Elias and Phat Tac Lau and thanks for blogging about it too. You
> might want to change the title of your post tho, tagging is not going
> to make it into Roller 2.1. We're currently evaluating Roller 2.1 RC2.
Sorry, I knew I was going to be off on that one. Fixed.
>
> I used the name "roller_2.1_tagging" because the branch is based on the
> 2.1 code-base. We might be able to get it into the Feb release (2.2) if
> we can get consensus that it is ready for trunk. I've downloaded your
> code and will be taking a look at it, I hope others will as well.
>
> - Dave
>
>
Cool.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFD4hZetsNTCOFcV0oRAn8qAKCAhKL3iYz12mUviYdcYFosebL2RACcDDqh
Kv1GTr0JIpt2VrVUVU1cfUc=
=Oq8E
-----END PGP SIGNATURE-----
Re: Tagging has arrived!
Posted by David M Johnson <Da...@Sun.COM>.
On Feb 2, 2006, at 1:00 AM, Elias Torres wrote:
> I just wanted to let you know that the much awaited *preliminary*
> tagging support in Roller (from IBM) has been checked in the tagging
> branch Dave created.
>
> Changes consist of the following:
>
> - - Added new table to createdb.vm to store tagging information
> - - Created new pojo and query results wrapper
> - - Modified the WeblogManager interface to support tags
> - - Implemented WeblogManager using a HibernateStrategy
> - - Modified WeblogEditEntry Form to enter tags
> - - Added new sidebar, tagcloud, etc to Main Page
>
> I want to take the opportunity to give credit to Phay Tac Lau
> (currently
> an IBM intern), who did most of the original development for this
> feature for our upcoming internal blogging release based on Roller
> 2.0.
>
> Let the discussion/development begin!
Thanks Elias and Phat Tac Lau and thanks for blogging about it too.
You might want to change the title of your post tho, tagging is not
going to make it into Roller 2.1. We're currently evaluating Roller
2.1 RC2.
I used the name "roller_2.1_tagging" because the branch is based on
the 2.1 code-base. We might be able to get it into the Feb release
(2.2) if we can get consensus that it is ready for trunk. I've
downloaded your code and will be taking a look at it, I hope others
will as well.
- Dave
Re: Tagging has arrived!
Posted by Henri Yandell <fl...@gmail.com>.
Sorry for being late on bringing this up.
I think we'll need to get a software grant on the Tagging work. See later email.
Hen
On 2/2/06, Elias Torres <el...@torrez.us> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi Folks,
>
> I just wanted to let you know that the much awaited *preliminary*
> tagging support in Roller (from IBM) has been checked in the tagging
> branch Dave created.
>
> Changes consist of the following:
>
> - - Added new table to createdb.vm to store tagging information
> - - Created new pojo and query results wrapper
> - - Modified the WeblogManager interface to support tags
> - - Implemented WeblogManager using a HibernateStrategy
> - - Modified WeblogEditEntry Form to enter tags
> - - Added new sidebar, tagcloud, etc to Main Page
>
> I want to take the opportunity to give credit to Phay Tac Lau (currently
> an IBM intern), who did most of the original development for this
> feature for our upcoming internal blogging release based on Roller 2.0.
>
> Let the discussion/development begin!
>
> - -Elias
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.1 (GNU/Linux)
>
> iD8DBQFD4aATtsNTCOFcV0oRAixgAJ9EF7dA0FkL/VNBqnTlS2V2iGJCMQCeJJy7
> 66uBhPNcDlr9RjcFo2osvDY=
> =C8hd
> -----END PGP SIGNATURE-----
>