You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Matej Knopp (JIRA)" <ji...@apache.org> on 2009/04/26 21:12:30 UTC
[jira] Commented: (WICKET-2130) Pages stored in
Session.touchedPages aren't detached when part of ModalWindow
[ https://issues.apache.org/jira/browse/WICKET-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12702921#action_12702921 ]
Matej Knopp commented on WICKET-2130:
-------------------------------------
I think your fix is correct. We have to detach the page there. It's better to detach some pages twice than to have pages not detached at all.
> Pages stored in Session.touchedPages aren't detached when part of ModalWindow
> -----------------------------------------------------------------------------
>
> Key: WICKET-2130
> URL: https://issues.apache.org/jira/browse/WICKET-2130
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.3.5, 1.4-RC2
> Reporter: Martijn Dashorst
> Fix For: 1.3.6, 1.4-RC3
>
> Attachments: wicket-2130.tgz
>
>
> Creating a ModalWindow with a Page causes the newly constructed page not to be detached.
> The page is stored in Session.touchedPages, but that list isn't properly processed at the end of the request for detaching.
> I'll try to create a testcase for this.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.