[GitHub] [flink] nielsbasjes commented on a change in pull request #12846: [FLINK-18448][pubsub] Update Google Cloud PubSub dependencies

[GitBox <gi...@apache.org>]

nielsbasjes commented on a change in pull request #12846:
URL: https://github.com/apache/flink/pull/12846#discussion_r457937728



##########
File path: flink-connectors/flink-connector-gcp-pubsub/pom.xml
##########
@@ -56,18 +56,22 @@ under the License.
 			<scope>provided</scope>
 		</dependency>
 
+		<dependency>
+			<groupId>com.google.cloud</groupId>
+			<artifactId>google-cloud-core</artifactId>
+			<!-- Version is pulled from google-cloud-bom (loaded via the libraries-bom) -->
+		</dependency>
+
 		<dependency>
 			<groupId>com.google.cloud</groupId>
 			<artifactId>google-cloud-pubsub</artifactId>
-			<!-- Version is pulled from google-cloud-bom -->
-			<exclusions>
-				<!-- Exclude an old version of guava that is being pulled
-                in by a transitive dependency of google-api-client -->
-				<exclusion>
-					<groupId>com.google.guava</groupId>
-					<artifactId>guava-jdk5</artifactId>
-				</exclusion>
-			</exclusions>
+			<!-- Version is pulled from google-cloud-bom (loaded via the libraries-bom) -->
+		</dependency>
+
+		<dependency>
+			<groupId>com.google.api.grpc</groupId>
+			<artifactId>grpc-google-cloud-pubsub-v1</artifactId>
+			<!-- Version is pulled from google-cloud-bom (loaded via the libraries-bom) -->

Review comment:
       No, this one is really needed. I also looked into this while writing it.
   Apparently this connector uses in a few places the com.google.pubsub.v1.SubscriberGrpc which is not included in the dependencies otherwise.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org