You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Sean Hsuan-Yi Chu <hs...@usc.edu> on 2015/04/08 02:34:45 UTC
Review Request 32947: DRILL-2717: Union-All reports new schema change
when there is actually no
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32947/
-----------------------------------------------------------
Review request for drill and Aman Sinha.
Bugs: DRILL-2717
https://issues.apache.org/jira/browse/DRILL-2717
Repository: drill-git
Description
-------
The upstream message returned by Union-All (when innerNext is called on Union-All) is corrected
Diffs
-----
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 61de3a4
exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 7033013
Diff: https://reviews.apache.org/r/32947/diff/
Testing
-------
QA, unit
Thanks,
Sean Hsuan-Yi Chu
Re: Review Request 32947: DRILL-2717: Union-All reports new schema
change when there is actually no
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
> On April 9, 2015, 6:48 a.m., Aman Sinha wrote:
> > exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java, line 444
> > <https://reviews.apache.org/r/32947/diff/1/?file=920328#file920328line444>
> >
> > You should name the columns explicitly in the subquery instead of relying on EXPR$0 which is a planner generated name and could change in the future.
I named this column explicitly as 'col0'
- Sean Hsuan-Yi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32947/#review79486
-----------------------------------------------------------
On April 8, 2015, 12:34 a.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32947/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 12:34 a.m.)
>
>
> Review request for drill and Aman Sinha.
>
>
> Bugs: DRILL-2717
> https://issues.apache.org/jira/browse/DRILL-2717
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> The upstream message returned by Union-All (when innerNext is called on Union-All) is corrected
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 61de3a4
> exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 7033013
>
> Diff: https://reviews.apache.org/r/32947/diff/
>
>
> Testing
> -------
>
> QA, unit
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 32947: DRILL-2717: Union-All reports new schema
change when there is actually no
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32947/#review79486
-----------------------------------------------------------
exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java
<https://reviews.apache.org/r/32947/#comment128895>
You should name the columns explicitly in the subquery instead of relying on EXPR$0 which is a planner generated name and could change in the future.
- Aman Sinha
On April 8, 2015, 12:34 a.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32947/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 12:34 a.m.)
>
>
> Review request for drill and Aman Sinha.
>
>
> Bugs: DRILL-2717
> https://issues.apache.org/jira/browse/DRILL-2717
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> The upstream message returned by Union-All (when innerNext is called on Union-All) is corrected
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 61de3a4
> exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 7033013
>
> Diff: https://reviews.apache.org/r/32947/diff/
>
>
> Testing
> -------
>
> QA, unit
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 32947: DRILL-2717: Union-All reports new schema
change when there is actually no
Posted by Aman Sinha <as...@maprtech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32947/#review79572
-----------------------------------------------------------
Ship it!
Ship It!
- Aman Sinha
On April 9, 2015, 5 p.m., Sean Hsuan-Yi Chu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32947/
> -----------------------------------------------------------
>
> (Updated April 9, 2015, 5 p.m.)
>
>
> Review request for drill and Aman Sinha.
>
>
> Bugs: DRILL-2717
> https://issues.apache.org/jira/browse/DRILL-2717
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> The upstream message returned by Union-All (when innerNext is called on Union-All) is corrected
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 61de3a4
> exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 7033013
>
> Diff: https://reviews.apache.org/r/32947/diff/
>
>
> Testing
> -------
>
> QA, unit
>
>
> Thanks,
>
> Sean Hsuan-Yi Chu
>
>
Re: Review Request 32947: DRILL-2717: Union-All reports new schema
change when there is actually no
Posted by Sean Hsuan-Yi Chu <hs...@usc.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32947/
-----------------------------------------------------------
(Updated April 9, 2015, 5 p.m.)
Review request for drill and Aman Sinha.
Changes
-------
updated patch
Bugs: DRILL-2717
https://issues.apache.org/jira/browse/DRILL-2717
Repository: drill-git
Description
-------
The upstream message returned by Union-All (when innerNext is called on Union-All) is corrected
Diffs (updated)
-----
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java 61de3a4
exec/java-exec/src/test/java/org/apache/drill/TestUnionAll.java 7033013
Diff: https://reviews.apache.org/r/32947/diff/
Testing
-------
QA, unit
Thanks,
Sean Hsuan-Yi Chu