You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/08 20:55:03 UTC
[GitHub] [beam] TheNeuralBit opened a new pull request, #22626: Add support for FLOAT to Python RowCoder
TheNeuralBit opened a new pull request, #22626:
URL: https://github.com/apache/beam/pull/22626
Part of #19815
This adds support for encoding the schema type FLOAT to Python's RowCoder. This is added in a new coder, `SinglePrecisionFloatCoder`, designed to be compatible with Java's `FloatCoder`.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #22626: Add support for FLOAT to Python RowCoder
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #22626:
URL: https://github.com/apache/beam/pull/22626#issuecomment-1208712464
Well I tried to modify Go's RowCoder but couldn't manage to get the test working right. Instead I've just skipped this case, and filed https://github.com/apache/beam/issues/22629 to track.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #22626: Add support for FLOAT to Python RowCoder
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #22626:
URL: https://github.com/apache/beam/pull/22626#issuecomment-1211071608
assign to next reviewer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #22626: Add support for FLOAT to Python RowCoder
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #22626:
URL: https://github.com/apache/beam/pull/22626#issuecomment-1210957907
@AnandInguva do you have time to review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22626: Add support for FLOAT to Python RowCoder
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22626:
URL: https://github.com/apache/beam/pull/22626#issuecomment-1211122015
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #22626: Add support for FLOAT to Python RowCoder
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #22626:
URL: https://github.com/apache/beam/pull/22626#issuecomment-1213385816
Run Go PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a diff in pull request #22626: Add support for FLOAT to Python RowCoder
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on code in PR #22626:
URL: https://github.com/apache/beam/pull/22626#discussion_r944795282
##########
model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml:
##########
@@ -455,6 +455,17 @@ examples:
---
+coder:
+ urn: "beam:coder:row:v1"
Review Comment:
This is a reference to row coder: https://github.com/apache/beam/blob/3173b503beaf30c4d32a4a39c709fd81e8161907/model/pipeline/src/main/proto/org/apache/beam/model/pipeline/v1/beam_runner_api.proto#L1062
Row Coder is a complex coder that is parameterized by a Beam Schema. It encodes different types of values by deferring to other coders, like `beam:coder:double:v1` for DOUBLE
##########
model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml:
##########
@@ -455,6 +455,17 @@ examples:
---
+coder:
+ urn: "beam:coder:row:v1"
+ # f_float: float32
Review Comment:
f_float here is the name of a field in the schema. We could call it "float" or "float32" instead, but it's not that important. I just followed the f_<type> convention used elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ryanthompson591 commented on a diff in pull request #22626: Add support for FLOAT to Python RowCoder
Posted by GitBox <gi...@apache.org>.
ryanthompson591 commented on code in PR #22626:
URL: https://github.com/apache/beam/pull/22626#discussion_r944724877
##########
model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml:
##########
@@ -455,6 +455,17 @@ examples:
---
+coder:
+ urn: "beam:coder:row:v1"
Review Comment:
can you double check this is not a typo. For example with double this is:
beam:coder:double:v1
I would suspect this should be
beam:coder:float:v1
##########
model/fn-execution/src/main/resources/org/apache/beam/model/fnexecution/v1/standard_coders.yaml:
##########
@@ -455,6 +455,17 @@ examples:
---
+coder:
+ urn: "beam:coder:row:v1"
+ # f_float: float32
Review Comment:
why f_float instead of float or float32?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a diff in pull request #22626: Add support for FLOAT to Python RowCoder
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on code in PR #22626:
URL: https://github.com/apache/beam/pull/22626#discussion_r944684801
##########
sdks/go/test/regression/coders/fromyaml/fromyaml.go:
##########
@@ -51,6 +51,7 @@ var unimplementedCoders = map[string]bool{
var filteredCases = []struct{ filter, reason string }{
{"logical", "BEAM-9615: Support logical types"},
{"30ea5a25-dcd8-4cdb-abeb-5332d15ab4b9", "https://github.com/apache/beam/issues/21206: Support encoding position."},
+ {"8c97b6c5-69e5-4733-907b-26cd8edae612", "https://github.com/apache/beam/issues/22629: Support single-precision float."},
Review Comment:
@jrmccluskey this test case is still failing in Go. It looks like it may just be a test infra issue, but I'm not able to debug on my own. Could you take a look?
I'm re-opening https://github.com/apache/beam/issues/22629 to track
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #22626: Add support for FLOAT to Python RowCoder
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #22626:
URL: https://github.com/apache/beam/pull/22626#issuecomment-1208751023
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] AnandInguva commented on pull request #22626: Add support for FLOAT to Python RowCoder
Posted by GitBox <gi...@apache.org>.
AnandInguva commented on PR #22626:
URL: https://github.com/apache/beam/pull/22626#issuecomment-1211007387
@TheNeuralBit I am on vacation. I will be back on Aug 22nd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #22626: Add support for FLOAT to Python RowCoder
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #22626:
URL: https://github.com/apache/beam/pull/22626#issuecomment-1208609859
@lostluck it looks like Go might be using the same coder for single-precision floats as for double-precision, is that right? From the Go PreCommit:
```
13:58:13 --- FAIL: TestStandardCoders (0.03s)
13:58:13 --- FAIL: TestStandardCoders/beam:coder:row:v1#06 (0.00s)
13:58:13 fromyaml_test.go:42: Failed "{beam:coder:row:v1
13:58:13
13:58:13 f_float$8c97b6c5-69e5-4733-907b-26cd8edae612 [] false}": err decoding "\x01\x00\x00\x00\x00\x00": decoding a struct { F_float float32 "beam:\"f_float\"" }
13:58:13 caused by:
13:58:13 error decoding double field
13:58:13 caused by:
13:58:13 EOF
13:58:13 FAIL
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #22626: Add support for FLOAT to Python RowCoder
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #22626:
URL: https://github.com/apache/beam/pull/22626#issuecomment-1208689400
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @AnandInguva for label python.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] jrmccluskey commented on a diff in pull request #22626: Add support for FLOAT to Python RowCoder
Posted by GitBox <gi...@apache.org>.
jrmccluskey commented on code in PR #22626:
URL: https://github.com/apache/beam/pull/22626#discussion_r944689361
##########
sdks/go/test/regression/coders/fromyaml/fromyaml.go:
##########
@@ -51,6 +51,7 @@ var unimplementedCoders = map[string]bool{
var filteredCases = []struct{ filter, reason string }{
{"logical", "BEAM-9615: Support logical types"},
{"30ea5a25-dcd8-4cdb-abeb-5332d15ab4b9", "https://github.com/apache/beam/issues/21206: Support encoding position."},
+ {"8c97b6c5-69e5-4733-907b-26cd8edae612", "https://github.com/apache/beam/issues/22629: Support single-precision float."},
Review Comment:
Can you share the output from the test failure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a diff in pull request #22626: Add support for FLOAT to Python RowCoder
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on code in PR #22626:
URL: https://github.com/apache/beam/pull/22626#discussion_r944717976
##########
sdks/go/test/regression/coders/fromyaml/fromyaml.go:
##########
@@ -51,6 +51,7 @@ var unimplementedCoders = map[string]bool{
var filteredCases = []struct{ filter, reason string }{
{"logical", "BEAM-9615: Support logical types"},
{"30ea5a25-dcd8-4cdb-abeb-5332d15ab4b9", "https://github.com/apache/beam/issues/21206: Support encoding position."},
+ {"8c97b6c5-69e5-4733-907b-26cd8edae612", "https://github.com/apache/beam/issues/22629: Support single-precision float."},
Review Comment:
Sorry I should have shared it to begin with but it had scrolled out of my shell history and I was lazy :grimacing:
I dropped the log in https://github.com/apache/beam/issues/22629#issuecomment-1213398732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #22626: Add support for FLOAT to Python RowCoder
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22626:
URL: https://github.com/apache/beam/pull/22626#issuecomment-1208626488
# [Codecov](https://codecov.io/gh/apache/beam/pull/22626?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22626](https://codecov.io/gh/apache/beam/pull/22626?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0cce0b3) into [master](https://codecov.io/gh/apache/beam/commit/cc0b446509fc07c48f4157c12189852fce62e817?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cc0b446) will **decrease** coverage by `0.01%`.
> The diff coverage is `80.00%`.
```diff
@@ Coverage Diff @@
## master #22626 +/- ##
==========================================
- Coverage 74.20% 74.18% -0.02%
==========================================
Files 708 708
Lines 93462 93487 +25
==========================================
+ Hits 69354 69358 +4
- Misses 22833 22854 +21
Partials 1275 1275
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `83.59% <80.00%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/22626?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ks/python/apache\_beam/coders/coders\_test\_common.py](https://codecov.io/gh/apache/beam/pull/22626/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyc190ZXN0X2NvbW1vbi5weQ==) | `98.54% <ø> (ø)` | |
| [sdks/python/apache\_beam/coders/coders.py](https://codecov.io/gh/apache/beam/pull/22626/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVycy5weQ==) | `88.00% <63.63%> (-0.35%)` | :arrow_down: |
| [sdks/python/apache\_beam/coders/coder\_impl.py](https://codecov.io/gh/apache/beam/pull/22626/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL2NvZGVyX2ltcGwucHk=) | `93.91% <85.71%> (-0.06%)` | :arrow_down: |
| [sdks/python/apache\_beam/coders/row\_coder.py](https://codecov.io/gh/apache/beam/pull/22626/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Jvd19jb2Rlci5weQ==) | `94.64% <100.00%> (+0.14%)` | :arrow_up: |
| [sdks/python/apache\_beam/coders/slow\_stream.py](https://codecov.io/gh/apache/beam/pull/22626/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vY29kZXJzL3Nsb3dfc3RyZWFtLnB5) | `94.69% <100.00%> (+0.19%)` | :arrow_up: |
| [.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/22626/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5) | `88.09% <0.00%> (-4.77%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/22626/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `78.26% <0.00%> (-1.45%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/22626/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.01% <0.00%> (-1.39%)` | :arrow_down: |
| [...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/22626/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=) | `90.06% <0.00%> (-1.33%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/localfilesystem.py](https://codecov.io/gh/apache/beam/pull/22626/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vbG9jYWxmaWxlc3lzdGVtLnB5) | `90.97% <0.00%> (-0.76%)` | :arrow_down: |
| ... and [3 more](https://codecov.io/gh/apache/beam/pull/22626/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #22626: Add support for FLOAT to Python RowCoder
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #22626:
URL: https://github.com/apache/beam/pull/22626#issuecomment-1208623222
Yes that does seem to be the case: https://github.com/apache/beam/blob/master/sdks/go/pkg/beam/core/graph/coder/row_encoder.go#L211-L214
Would you be opposed to me sending a change to encode as single-precision in that case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #22626: Add support for FLOAT to Python RowCoder
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #22626:
URL: https://github.com/apache/beam/pull/22626#issuecomment-1211120662
R: @tvalentyn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on a diff in pull request #22626: Add support for FLOAT to Python RowCoder
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on code in PR #22626:
URL: https://github.com/apache/beam/pull/22626#discussion_r942970125
##########
sdks/go/test/regression/coders/fromyaml/fromyaml.go:
##########
@@ -51,6 +51,7 @@ var unimplementedCoders = map[string]bool{
var filteredCases = []struct{ filter, reason string }{
{"logical", "BEAM-9615: Support logical types"},
{"30ea5a25-dcd8-4cdb-abeb-5332d15ab4b9", "https://github.com/apache/beam/issues/21206: Support encoding position."},
+ {"8c97b6c5-69e5-4733-907b-26cd8edae612", "https://github.com/apache/beam/issues/22629: Support single-precision float."},
Review Comment:
Noting there's a race with #22664. Whichever is merged later should remove this exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit commented on pull request #22626: Add support for FLOAT to Python RowCoder
Posted by GitBox <gi...@apache.org>.
TheNeuralBit commented on PR #22626:
URL: https://github.com/apache/beam/pull/22626#issuecomment-1211365930
Oops Valentyn is also out
R: @ryanthompson591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] TheNeuralBit merged pull request #22626: Add support for FLOAT to Python RowCoder
Posted by GitBox <gi...@apache.org>.
TheNeuralBit merged PR #22626:
URL: https://github.com/apache/beam/pull/22626
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org