You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by sh...@apache.org on 2021/07/09 13:01:34 UTC
[unomi] branch unomi-1.5.x updated: UNOMI-493 Fix missing profile
ID on Segment integration tests. (#315)
This is an automated email from the ASF dual-hosted git repository.
shuber pushed a commit to branch unomi-1.5.x
in repository https://gitbox.apache.org/repos/asf/unomi.git
The following commit(s) were added to refs/heads/unomi-1.5.x by this push:
new 404aecf UNOMI-493 Fix missing profile ID on Segment integration tests. (#315)
404aecf is described below
commit 404aecf3473b095c32a8e25b52885fc176b50dae
Author: Serge Huber <sh...@jahia.com>
AuthorDate: Fri Jul 9 14:58:49 2021 +0200
UNOMI-493 Fix missing profile ID on Segment integration tests. (#315)
This is fixed by adding a dummy profile ID for validation purposes
(cherry picked from commit 26668989b6061b589226a7bd29b258379c242468)
---
.../org/apache/unomi/services/impl/segments/SegmentServiceImpl.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/services/src/main/java/org/apache/unomi/services/impl/segments/SegmentServiceImpl.java b/services/src/main/java/org/apache/unomi/services/impl/segments/SegmentServiceImpl.java
index 7c03503..afe551f 100644
--- a/services/src/main/java/org/apache/unomi/services/impl/segments/SegmentServiceImpl.java
+++ b/services/src/main/java/org/apache/unomi/services/impl/segments/SegmentServiceImpl.java
@@ -63,6 +63,7 @@ public class SegmentServiceImpl extends AbstractServiceImpl implements SegmentSe
private static final Logger logger = LoggerFactory.getLogger(SegmentServiceImpl.class.getName());
+ private static final String VALIDATION_PROFILE_ID = "validation-profile-id";
private BundleContext bundleContext;
private EventService eventService;
@@ -268,7 +269,7 @@ public class SegmentServiceImpl extends AbstractServiceImpl implements SegmentSe
public void setSegmentDefinition(Segment segment) {
ParserHelper.resolveConditionType(definitionsService, segment.getCondition(), "segment " + segment.getItemId());
- if (!persistenceService.isValidCondition(segment.getCondition(), new Profile())) {
+ if (!persistenceService.isValidCondition(segment.getCondition(), new Profile(VALIDATION_PROFILE_ID))) {
throw new BadSegmentConditionException();
}