You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/07/06 20:07:31 UTC

[GitHub] [pulsar-client-go] merlimat commented on a change in pull request #309: [Issue 306] Change connection failed warn log to error and print error message

merlimat commented on a change in pull request #309:
URL: https://github.com/apache/pulsar-client-go/pull/309#discussion_r450452438



##########
File path: pulsar/internal/connection.go
##########
@@ -287,8 +287,8 @@ func (c *connection) doHandshake() bool {
 	c.cnx.SetDeadline(time.Time{})
 
 	if cmd.Connected == nil {
-		c.log.Warnf("Failed to perform initial handshake - Expecting 'Connected' cmd, got '%s'",
-			cmd.Type)
+		c.log.Errorf("Failed to perform initial handshake - Expecting 'Connected' cmd, got '%s'",

Review comment:
       The message itself need to be changed though. It was basically a "debug" message. In this case, the user doesn't know what's a `Connected cmd`. 
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org