[jira] [Commented] (MADLIB-1316) Simplify madlib_keras_predict interface

["Frank McQuillan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MADLIB-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16824356#comment-16824356 ] 

Frank McQuillan commented on MADLIB-1316:
-----------------------------------------

https://github.com/apache/madlib/pull/370

> Simplify madlib_keras_predict interface
> ---------------------------------------
>
>                 Key: MADLIB-1316
>                 URL: https://issues.apache.org/jira/browse/MADLIB-1316
>             Project: Apache MADlib
>          Issue Type: Improvement
>          Components: Deep Learning
>            Reporter: Nandish Jayaram
>            Priority: Major
>             Fix For: v1.16
>
>
> The interface for `madlib_keras_predict()` is currently more complex than necessary. The following params that are currently needed can be inferred from model/model_summary table:
> 1. `model_arch_table`
> 2. `model_arch_id`
> 3. `compile_params`
> These params are passed to `madlib_keras_fit()`, and we should just store them in the model output summary table. Any model we learn in fit is very specific to these params and they should not be changed while calling predict anyway.
> The following proposed predict interface is simpler and sufficient:
> {code}
> madlib_keras_predict(
>     model_table            VARCHAR,
>     test_table                 VARCHAR,
>     id_col                        VARCHAR,
>     independent_varname     VARCHAR,
>     output_table            VARCHAR
>     pred_type                 VARCHAR
> )
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)