You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/09/27 13:44:19 UTC
[GitHub] [storm] srdo commented on a change in pull request #3132:
STORM-3186: Customizable configuration for metric reporting interval
srdo commented on a change in pull request #3132: STORM-3186: Customizable configuration for metric reporting interval
URL: https://github.com/apache/storm/pull/3132#discussion_r329072691
##########
File path: storm-server/src/main/java/org/apache/storm/DaemonConfig.java
##########
@@ -74,6 +74,12 @@
@IsString
public static final String STORM_DAEMON_METRICS_REPORTER_PLUGIN_DOMAIN = "storm.daemon.metrics.reporter.plugin.domain";
+ /**
+ * We report the metrics with this interval period.
+ */
+ @IsString
+ public static final String STORM_DAEMON_METRICS_REPORTER_INTERVAL_PERIOD = "storm.daemon.metrics.reporter.interval.period";
Review comment:
Please rename so we include the time unit, e.g. "storm.daemon.metrics.reporter.interval.secs"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services