You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by richardcloudsoft <gi...@git.apache.org> on 2014/07/07 17:17:04 UTC
[GitHub] incubator-brooklyn pull request: POM dependency version fixes
GitHub user richardcloudsoft opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/50
POM dependency version fixes
An attempt to sanitise the versions of our dependencies, while in the process of working on BROOKLYN-21. This pull request addresses:
* References to JUnit in our tests. These should all be to TestNG
* Some components depend on the same artifact with different versions - change these so the same version number is used in all places that depend on it. Where there is a conflict, the earlier version is upgraded to match the later version.
* All dependency versions should be addressed by defining a constant property for the version number in the root POM, and using the `dependencyManagement` section to make this the default. Child POMs should not mention a version number.
* A couple of other minor issues
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/richardcloudsoft/incubator-brooklyn pom-dependency-fixes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/50.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #50
----
commit 31d30d53aa2a5402cc8ae3ea6a421ac54635785a
Author: Richard Downer <ri...@apache.org>
Date: 2014-07-07T13:03:14Z
Fix IntelliJ compilation oddity
The code as it was does not build in IntelliJ, although the IDE editor
does not detect there is a problem; only at compile time. The change
fixes the compilation issue without changing the behaviour.
commit e800bea6d8046d4733f17a170324ff09efc36503
Author: Richard Downer <ri...@apache.org>
Date: 2014-07-04T15:19:44Z
Change junit references to TestNG
All probably the result of accepting an IDE's suggested `import` without
looking closely!
commit 9b1cbb6e8892d5dc578c2cad508d173d14cb761a
Author: Richard Downer <ri...@apache.org>
Date: 2014-07-07T13:12:06Z
brooklyn-software-osgi, change OSGi dependency ref
Was previously org.osgi:core:4.3.0; changed to
org.osgi:org.osgi.core:4.3.0 to match usage/launcher/pom.xml reference
to OSGi
commit a513d8e127c24107afeb7a962daafb9b4f9fd955
Author: Richard Downer <ri...@apache.org>
Date: 2014-07-07T14:04:36Z
Fix interior version conflicts - qpid
commit d6944861c8b1168d6759da0b1716f1d943c7a23a
Author: Richard Downer <ri...@apache.org>
Date: 2014-07-07T14:10:57Z
Fix interior version conflicts - slf4j
commit 342a00dd2e59cfbd5f3747bac623221ce27db156
Author: Richard Downer <ri...@apache.org>
Date: 2014-07-07T14:13:11Z
Fix interior version conflicts - MongoDB
commit b0a5d2ca67401b87f6ca393e5da4c223a2f5fdd3
Author: Richard Downer <ri...@apache.org>
Date: 2014-07-07T14:14:49Z
Fix interior version conflicts - maven-war-plugin
commit 2cf8065c7ee89044f03529fdb6575654c5db8a8e
Author: Richard Downer <ri...@apache.org>
Date: 2014-07-07T14:40:42Z
Missing dependencies on TestNG
commit 3c49dbf5f7e6a65edea43f794b8ca9ff6ff854a4
Author: Richard Downer <ri...@apache.org>
Date: 2014-07-04T16:54:45Z
Specify version numbers in root pom.xml only
This removes any hard-coded version numbers from pom.xml except for the
root; the root contains a set of properties that define version numbers.
In some cases this will change the minor version used; where this
happens, the version used will always move forward, not backward; and
the major version does not change.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: POM dependency version fixes
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/50#issuecomment-48448696
Changes look good.
Will leave to @andreaturli to review+test, and to do the merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: POM dependency version fixes
Posted by andreaturli <gi...@git.apache.org>.
Github user andreaturli commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/50#issuecomment-48450194
lgtm
I've checked with `mvn dependency:tree` and `mvn org.apache.maven.plugins:maven-dependency-plugin:2.2:analyze-duplicate` and everything looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: POM dependency version fixes
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/50
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---