You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/08/10 22:58:42 UTC
[GitHub] [commons-lang] nishantc1527 opened a new pull request #602: Made String Reverse Method Faster
nishantc1527 opened a new pull request #602:
URL: https://github.com/apache/commons-lang/pull/602
Right now, StringUtils.reverse() is done the lazy way by initializing a new Stringbuilder, calling reverse, then converting back into a string. I filled out the reverse method by doing it manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] XenoAmess commented on pull request #602: Made String Reverse Method Faster
Posted by GitBox <gi...@apache.org>.
XenoAmess commented on pull request #602:
URL: https://github.com/apache/commons-lang/pull/602#issuecomment-672609982
> @XenoAmess
> Let's be careful with the terms we use here: this PR does NOT break BC. BC is about API signatures, not behavior.
@garydgregory Oh yes. thanks for the clarification.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] nishantc1527 commented on pull request #602: Made String Reverse Method Faster
Posted by GitBox <gi...@apache.org>.
nishantc1527 commented on pull request #602:
URL: https://github.com/apache/commons-lang/pull/602#issuecomment-672558936
Never mind, I think ```StringBuilder```'s reverse method is better. Sorry for wasting anyone's time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls edited a comment on pull request #602: Made String Reverse Method Faster
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #602:
URL: https://github.com/apache/commons-lang/pull/602#issuecomment-671633372
[](https://coveralls.io/builds/32661981)
Coverage increased (+0.01%) to 94.666% when pulling **2a07a009c4d4d4be044f121637ec3b01242ea36b on nishantc1527:master** into **9f52471fab5bf82db3d2f9e0086bf3c56c894ec6 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] nishantc1527 edited a comment on pull request #602: Made String Reverse Method Faster
Posted by GitBox <gi...@apache.org>.
nishantc1527 edited a comment on pull request #602:
URL: https://github.com/apache/commons-lang/pull/602#issuecomment-672546570
> Hi.
> It actually breaks BC...
> the original code can handle surrogate pairs.
> you can see details in StringBuilder's source codes.
Sorry, I don't know what surrogate pairs are... do you mind explaining?
> besides, you should run a jmh test to show the performance incresement.
> see HashSetvBitSetTest for example.
Sorry again, I'm not used to using jmh. I'm looking it up on google, I'll be back in a bit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] XenoAmess commented on pull request #602: Made String Reverse Method Faster
Posted by GitBox <gi...@apache.org>.
XenoAmess commented on pull request #602:
URL: https://github.com/apache/commons-lang/pull/602#issuecomment-671747922
besides, you should run a jmh test to show the performance incresement.
see HashSetvBitSetTest for example.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] garydgregory commented on pull request #602: Made String Reverse Method Faster
Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #602:
URL: https://github.com/apache/commons-lang/pull/602#issuecomment-672549248
@XenoAmess
Let's be careful with the terms we use here: this PR does NOT break BC. BC is about API signatures, not behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] nishantc1527 commented on pull request #602: Made String Reverse Method Faster
Posted by GitBox <gi...@apache.org>.
nishantc1527 commented on pull request #602:
URL: https://github.com/apache/commons-lang/pull/602#issuecomment-672546570
> Hi.
> It actually breaks BC...
> the original code can handle surrogate pairs.
> you can see details in StringBuilder's source codes.
Sorry, I don't know what surrogate pairs are... do you mind explaining?
> besides, you should run a jmh test to show the performance incresement.
> see HashSetvBitSetTest for example.
Doing that now!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] XenoAmess commented on pull request #602: Made String Reverse Method Faster
Posted by GitBox <gi...@apache.org>.
XenoAmess commented on pull request #602:
URL: https://github.com/apache/commons-lang/pull/602#issuecomment-671747098
Hi.
It actually breaks BC...
the original code can handle surrogate pairs.
you can see details in StringBuilder's source.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] coveralls commented on pull request #602: Made String Reverse Method Faster
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #602:
URL: https://github.com/apache/commons-lang/pull/602#issuecomment-671633372
[](https://coveralls.io/builds/32661495)
Coverage increased (+0.01%) to 94.666% when pulling **e3a30ea45a18fab29719d3fc82038fb4b0e2df56 on nishantc1527:master** into **9f52471fab5bf82db3d2f9e0086bf3c56c894ec6 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] XenoAmess edited a comment on pull request #602: Made String Reverse Method Faster
Posted by GitBox <gi...@apache.org>.
XenoAmess edited a comment on pull request #602:
URL: https://github.com/apache/commons-lang/pull/602#issuecomment-671747098
Hi.
It actually breaks BC...
the original code can handle surrogate pairs.
you can see details in StringBuilder's source codes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-lang] nishantc1527 closed pull request #602: Made String Reverse Method Faster
Posted by GitBox <gi...@apache.org>.
nishantc1527 closed pull request #602:
URL: https://github.com/apache/commons-lang/pull/602
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org