You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by "robertdale (GitHub)" <gi...@apache.org> on 2019/11/06 03:44:00 UTC

[GitHub] [tinkerpop] robertdale opened pull request #1213: Reverts TINKERPOP-2289 resolve ip address

See:
1.  [User list](https://groups.google.com/d/msg/gremlin-users/A9rr9jLh5AY/DLguF9QmAQAJ)
2. [Dev list]()

[ Full content available at: https://github.com/apache/tinkerpop/pull/1213 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #1213: Reverts TINKERPOP-2289 resolve ip address

Posted by "spmallette (GitHub)" <gi...@apache.org>.

I think revert is a good first step here. Depending upon how the dev list thread goes we can figure out if new JIRA issues are required. Aside from a CHANGELOG entry this looks good to me. 

@olivertowers if you have a moment to test this branch with CosmosDB to validate that all is good, that would be hugely helpful. if it would be helpful to have a fresh SNAPSHOT published with this change I can do that ..just let me know.  cc/ @luisbosquez

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1213 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #1213: Reverts TINKERPOP-2289 resolve ip address

Posted by "spmallette (GitHub)" <gi...@apache.org>.

didn't fix it 😞 🤔 

[ Full content available at: https://github.com/apache/tinkerpop/pull/1213 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #1213: Reverts TINKERPOP-2289 resolve ip address

Posted by "spmallette (GitHub)" <gi...@apache.org>.

hmm - passed - tried merging this change forward to `travis-fix` which is based on `tp34`. maybe we get a clean build now: 

https://travis-ci.org/apache/tinkerpop/builds/609643926

[ Full content available at: https://github.com/apache/tinkerpop/pull/1213 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #1213: Reverts TINKERPOP-2289 resolve ip address

Posted by "spmallette (GitHub)" <gi...@apache.org>.

thanks for testing @olivertowers - i've published fresh snapshots for all release branches.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1213 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org