You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by "Jordan Zimmerman (JIRA)" <ji...@apache.org> on 2016/12/23 13:26:58 UTC

[jira] [Commented] (CURATOR-370) Replace use of MoreExecutors.sameThreadExecutor

    [ https://issues.apache.org/jira/browse/CURATOR-370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15772895#comment-15772895 ] 

Jordan Zimmerman commented on CURATOR-370:
------------------------------------------

We should fix this issue, but we really need to Shade Guava into Curator and remove the external dependency altogether.

> Replace use of MoreExecutors.sameThreadExecutor
> -----------------------------------------------
>
>                 Key: CURATOR-370
>                 URL: https://issues.apache.org/jira/browse/CURATOR-370
>             Project: Apache Curator
>          Issue Type: Improvement
>    Affects Versions: 3.2.1, 2.11.1
>            Reporter: Simon Cooper
>            Assignee: Jordan Zimmerman
>              Labels: dependencies
>
> {{ListenerContainer}} has a reference to {{MoreExecutors.sameThreadExecutor}} in guava. This method has been deprecated since guava version 18.0, and is being removed in version 21.0. This should be changed to use {{MoreExecutors.directExecutor}} instead.
> The use of this method means that all projects using Curator can't use a guava version past 20.0, as the method no longer exists in 21, so I would say this is quite high priority to fix, especially since 21.0 is the first Java 8 version of guava.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)