[jira] [Commented] (COUCHDB-1689) CORS requests on attachments sometimes fail

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/COUCHDB-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598393#comment-13598393 ] 

ASF subversion and git services commented on COUCHDB-1689:
----------------------------------------------------------

Commit b0420f9006915149e81607615720f32f21c76725 in branch refs/heads/master from [~vmx]
[ https://git-wip-us.apache.org/repos/asf?p=couchdb.git;h=b0420f9 ]

Fix CORS error with attachments

When attachments were returned (?attachments=true) while CORS was
enabled and used, an error occured. The reason for this error
were headers that were encoded as binaries instead of lists. String
operations on binaries throw errors.

This commit fixes COUCHDB-1689.

                
> CORS requests on attachments sometimes fail
> -------------------------------------------
>
>                 Key: COUCHDB-1689
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1689
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Database Core
>            Reporter: Volker Mische
>
> In some cases CORS requests fail. I've identified two cases:
>  1. when using CORS and requesting attachments with doc?attachments=true the request failes
>  2. When an uncompressed attachments is requested directly with a range request
> The reason is that in those cases headers are encoded as binaries instead of lists. CORS is doing some string manipulations (string:to_lower/1) which fails when it gets binaries.
> Pull request with tests and fix is forthcoming.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira