You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/12/14 07:27:23 UTC

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #896: createnetwork: Fixing missing vlan parameter

davidjumani commented on a change in pull request #896:
URL: https://github.com/apache/cloudstack-primate/pull/896#discussion_r542163681



##########
File path: src/views/network/CreateNetwork.vue
##########
@@ -18,24 +18,24 @@
 <template>
   <div class="form-layout">
     <a-tabs defaultActiveKey="1" :animated="false">
-      <a-tab-pane :tab="$t('label.isolated')" key="1" v-if="this.isAdvancedZoneWithoutSGAvailable()">
-        <CreateIsolatedNetworkForm
+      <a-tab-pane :tab="$t('label.l2')" key="1">

Review comment:
       It can, but then l2 form pops open first since the if condition on the isolated form takes time to evaluate, and the reordering of the tabs once evaluated looks messy




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org