[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #19154: Address Leo's comments on PR#18704

[GitBox <gi...@apache.org>]

Zha0q1 commented on a change in pull request #19154:
URL: https://github.com/apache/incubator-mxnet/pull/19154#discussion_r488973512



##########
File path: tests/python/gpu/test_profiler_gpu.py
##########
@@ -23,12 +23,16 @@
 import mxnet as mx
 mx.test_utils.set_default_context(mx.gpu(0))
 
+from mxnet.gluon.block import _block_scope
+
 curr_path = os.path.dirname(os.path.abspath(os.path.expanduser(__file__)))
 sys.path.insert(0, os.path.join(curr_path, '../unittest'))
-from mxnet import profiler
-from mxnet.gluon import nn
-from mxnet.gluon.block import _block_scope
-from test_profiler import enable_profiler
+# We import all tests from ../unittest/test_profiler.py
+# They will be detected by test framework, as long as the current file has a different filename
+from test_profiler import *
+# Test seen to crash pytest worker during development of
+# https://github.com/apache/incubator-mxnet/pull/18694
+del test_aggregate_duplication

Review comment:
       Can you share the error message? I just copied out and ran this test on a gpu instance and it did not fail. This test was added in a pr that fixes the operator invocation count bing 2X of the actual number issue. All it does is just create a tensor, do some operations on it, and check if count is correct




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org