[jira] [Commented] (CAMEL-9236) Tokenize with regex grouping has a small bug

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-9236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14963583#comment-14963583 ] 

ASF GitHub Bot commented on CAMEL-9236:
---------------------------------------

GitHub user duro1 opened a pull request:

    https://github.com/apache/camel/pull/651

    CAMEL-9236 Bug fix to pass group to the helper delegate

    Issue resolved by passing the group parameter to the helper object.
    
    Note: The splitter will use the token passed in as the delimiter between items in the group.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/duro1/camel master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/camel/pull/651.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #651
    
----
commit b4df911cf3d9e5ceecb7e3485127999dfae69ff1
Author: unknown <du...@yahoo.com>
Date:   2015-10-16T16:08:01Z

    Bug fix to pass group to the helper delegate

----


> Tokenize with regex grouping has a small bug
> --------------------------------------------
>
>                 Key: CAMEL-9236
>                 URL: https://issues.apache.org/jira/browse/CAMEL-9236
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-core
>    Affects Versions: 2.15.0, 2.15.1, 2.15.2, 2.15.3, 2.16.0
>            Reporter: Chad Durovec
>            Priority: Minor
>             Fix For: Future
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> Looks like a copy/paste error is preventing the grouping functionality from being executed by the helper object. 
> group should be passed to the delegate's tokenize method. 
> camel-core/src/main/java/org/apache/camel/builder/ExpressionClause.java 
>     /** 
>      * Evaluates a token expression on the message body 
>      * 
>      * @param token the token 
>      * @param regex whether the token is a regular expression or not 
>      * @param group to group by the given number 
>      * @return the builder to continue processing the DSL 
>      */ 
>     public T tokenize(String token, boolean regex, int group) { 
>         return delegate.tokenize(token, regex); 
>     } 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)