You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@geode.apache.org by joeymcallister <gi...@git.apache.org> on 2016/10/20 20:56:45 UTC

[GitHub] incubator-geode pull request #267: Feature/geode 2015

GitHub user joeymcallister opened a pull request:

    https://github.com/apache/incubator-geode/pull/267

    Feature/geode 2015

    Changes to docs and site directories for adding the documentation/user guide to the Geode website.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/joeymcallister/incubator-geode feature/GEODE-2015

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-geode/pull/267.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #267
    
----
commit 20d08fdb92f0b2f0c5b913d8cf3de13adfe1ce7e
Author: Joey McAllister <jm...@pivotal.io>
Date:   2016-10-19T17:33:19Z

    GEODE-2015: Edit links to docs info

commit d942321f985173323ae623ba0a08473a28fb91e4
Author: Joey McAllister <jm...@pivotal.io>
Date:   2016-10-19T17:44:55Z

    GEODE-2015: Add images_svg, stylesheets to Rules passthrough

commit 8fee2c29c4253da344306f4b6f4378de4b7b98d5
Author: Joey McAllister <jm...@pivotal.io>
Date:   2016-10-19T19:39:53Z

    GEODE-2015: Fix extension for Bookbinder update

commit c9bf95e6a3c22c6f61927ca19209f92f8a43177c
Author: Joey McAllister <jm...@pivotal.io>
Date:   2016-10-19T19:44:27Z

    GEODE-2015: Update GemFire.lock for Bookbinder 10.0.2

commit 387f2a5ca59607300d55021ab0d246104c68a758
Author: Joey McAllister <jm...@pivotal.io>
Date:   2016-10-20T16:27:37Z

    Revert "GEODE-2015: Add images_svg, stylesheets to Rules passthrough"
    
    This reverts commit d942321f985173323ae623ba0a08473a28fb91e4.

commit c14971901dc0fed938f97b684f3eecee64691491
Author: Joey McAllister <jm...@pivotal.io>
Date:   2016-10-20T18:44:12Z

    GEODE-2015: Point user guide link to new location

commit 6bd8a6b171188d25b66dcdc5eda72c37b8db6035
Author: Joey McAllister <jm...@pivotal.io>
Date:   2016-10-20T18:47:50Z

    GEODE-2015: Edit docs to work better with site

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request #267: Feature/geode 2015

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-geode/pull/267


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #267: Feature/geode 2015

Posted by joeymcallister <gi...@git.apache.org>.

Github user joeymcallister commented on the issue:

    https://github.com/apache/incubator-geode/pull/267
  
    @karensmolermiller I committed a new README.md file with the two changes you suggested. My markdown editors showed the correct formatting before the changes, as well as after the changes. Please review to make sure they're registering in your markdown editor.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #267: Feature/geode 2015

Posted by davebarnes97 <gi...@git.apache.org>.

Github user davebarnes97 commented on the issue:

    https://github.com/apache/incubator-geode/pull/267
  
    Correction - bookbinder watch did not work reliably for me, so this PR does not introduce a new problem.
    Re-verified that local bind yields good output.
    
    IMO, OK to accept this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #267: Feature/geode 2015

Posted by karensmolermiller <gi...@git.apache.org>.

Github user karensmolermiller commented on the issue:

https://github.com/apache/incubator-geode/pull/267

+1 on this PR with two minor alterations in the `geode-book/README.md` file:

- the markdown is not quite right. Adding appropriate blank lines and indenting the fixed width text sections by 4 spaces will make the last section's 4 numbered items appear as 1, 2, 3, 4. They currently appear as 1, 1, 1, 1.
- the first of the 3 commands to embed the User Guide into the website content (what will be step number 2) is missing a period at the end of the command.
The *incorrect* commands:

```
$ tar cvf ~/Desktop/new-guide-content.tar
$ cd ../../../geode-site/content
$ tar xvf ~/Desktop/new-guide-content.tar
```

The correct commands are

```
$ tar cvf ~/Desktop/new-guide-content.tar .
$ cd ../../../geode-site/content
$ tar xvf ~/Desktop/new-guide-content.tar
```

_Note:_ when merging in this PR to a current develop branch, there will be a conflict (as noted in the PR) on the subnav. Keep the develop branch's (new) link to the Automated Rebalance section, but update its path to include `/guide`.

---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #267: Feature/geode 2015

Posted by upthewaterspout <gi...@git.apache.org>.

Github user upthewaterspout commented on the issue:

    https://github.com/apache/incubator-geode/pull/267
  
    Changes look good. I think there needs to be some changes to geode-site/website/README.md to instruct people to build the docs and include them in the website though. Otherwise someone might build and push the website with the docs missing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #267: Feature/geode 2015

Posted by joeymcallister <gi...@git.apache.org>.

Github user joeymcallister commented on the issue:

    https://github.com/apache/incubator-geode/pull/267
  
    Agreed. Working on that now. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode issue #267: Feature/geode 2015

Posted by davebarnes97 <gi...@git.apache.org>.

Github user davebarnes97 commented on the issue:

https://github.com/apache/incubator-geode/pull/267

Pulled & tested. I was especially concerned about the change in redirects from ../doc to ../guide. Local bookbinder bind works. Bookbinder 'watch', which worked for me before, throws errors from various Ruby gems. Not sure that support for bookbinder 'watch' is important, so maybe this doesn't matter. Sample of errors:

$ bundle exec bookbinder watch
Gathering geode-docs
copying /Users/dbarnes/Repo/incubator-geode/geode-docs

Running middleman...

== The Middleman is loading
== LiveReload accepting connections from ws://192.168.1.80:35729
E, [2016-10-21T11:30:42.281013 #71727] ERROR -- : exception while processing events: Is a directory @ io_fread - /Users/dbarnes/Repo/incubator-geode/geode-book/output/master_middleman/source/guide Backtrace:

-- /Users/dbarnes/.rvm/gems/ruby-2.3.0/gems/middleman-core-4.1.10/lib/middleman-core/util/binary.rb:70:in `read'

-- /Users/dbarnes/.rvm/gems/ruby-2.3.0/gems/middleman-core-4.1.10/lib/middleman-core/util/binary.rb:70:in `file_contents_include_binary_bytes?'

-- /Users/dbarnes/.rvm/gems/ruby-2.3.0/gems/middleman-core-4.1.10/lib/middleman-core/util/binary.rb:38:in `binary?'

-- /Users/dbarnes/.rvm/gems/ruby-2.3.0/gems/middleman-core-4.1.10/lib/middleman-core/sitemap/resource.rb:175:in `binary?'

...and so on.