You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/23 02:36:31 UTC
[GitHub] [spark] Ngone51 commented on a change in pull request #34043: [SPARK-36782][CORE] Avoid blocking dispatcher-BlockManagerMaster during UpdateBlockInfo
Ngone51 commented on a change in pull request #34043:
URL: https://github.com/apache/spark/pull/34043#discussion_r714433856
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManagerMasterEndpoint.scala
##########
@@ -117,12 +117,15 @@ class BlockManagerMasterEndpoint(
case _updateBlockInfo @
UpdateBlockInfo(blockManagerId, blockId, storageLevel, deserializedSize, size) =>
- val isSuccess = updateBlockInfo(blockManagerId, blockId, storageLevel, deserializedSize, size)
- context.reply(isSuccess)
- // SPARK-30594: we should not post `SparkListenerBlockUpdated` when updateBlockInfo
- // returns false since the block info would be updated again later.
- if (isSuccess) {
- listenerBus.post(SparkListenerBlockUpdated(BlockUpdatedInfo(_updateBlockInfo)))
+ val response = updateBlockInfo(blockManagerId, blockId, storageLevel, deserializedSize, size)
+
+ response.foreach { isSuccess =>
+ // SPARK-30594: we should not post `SparkListenerBlockUpdated` when updateBlockInfo
+ // returns false since the block info would be updated again later.
+ if (isSuccess) {
+ listenerBus.post(SparkListenerBlockUpdated(BlockUpdatedInfo(_updateBlockInfo)))
+ }
+ context.reply(isSuccess)
Review comment:
This causes the responses of non-shuffle blocks also be handled in the thread pool. I'm afraid this introduces unexpected overhead. Shall we only do this for the shuffle blocks only and leave the non-shuffle blocks the same behaviour?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org