You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/06/23 08:22:27 UTC
[GitHub] [maven-resolver] michael-o opened a new pull request #62: [MRESOLVER-127] Don't use boolean for property 'aether.updateCheckMan…
michael-o opened a new pull request #62:
URL: https://github.com/apache/maven-resolver/pull/62
…ager.sessionState'
This closes #62
@kwin Have a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] kwin commented on a change in pull request #62: [MRESOLVER-127] Don't use boolean for property 'aether.updateCheckMan…
Posted by GitBox <gi...@apache.org>.
kwin commented on a change in pull request #62:
URL: https://github.com/apache/maven-resolver/pull/62#discussion_r444049194
##########
File path: maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManagerTest.java
##########
@@ -338,11 +338,11 @@ public void testCheckMetadataSessionStateModes()
resetSessionData( session );
manager.touchMetadata( session, check );
- session.setConfigProperty( DefaultUpdateCheckManager.CONFIG_PROP_SESSION_STATE, "true" );
+ session.setConfigProperty( DefaultUpdateCheckManager.CONFIG_PROP_SESSION_STATE, "enabled" );
manager.checkMetadata( session, check );
assertEquals( false, check.isRequired() );
- session.setConfigProperty( DefaultUpdateCheckManager.CONFIG_PROP_SESSION_STATE, "false" );
+ session.setConfigProperty( DefaultUpdateCheckManager.CONFIG_PROP_SESSION_STATE, "disabled" );
Review comment:
for backwards compatibility reasons I would still leave the old test cases in place relying on `true` or `false`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a change in pull request #62: [MRESOLVER-127] Don't use boolean for property 'aether.updateCheckMan…
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #62:
URL: https://github.com/apache/maven-resolver/pull/62#discussion_r444049892
##########
File path: maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManagerTest.java
##########
@@ -338,11 +338,11 @@ public void testCheckMetadataSessionStateModes()
resetSessionData( session );
manager.touchMetadata( session, check );
- session.setConfigProperty( DefaultUpdateCheckManager.CONFIG_PROP_SESSION_STATE, "true" );
+ session.setConfigProperty( DefaultUpdateCheckManager.CONFIG_PROP_SESSION_STATE, "enabled" );
manager.checkMetadata( session, check );
assertEquals( false, check.isRequired() );
- session.setConfigProperty( DefaultUpdateCheckManager.CONFIG_PROP_SESSION_STATE, "false" );
+ session.setConfigProperty( DefaultUpdateCheckManager.CONFIG_PROP_SESSION_STATE, "disabled" );
Review comment:
Makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] asfgit closed pull request #62: [MRESOLVER-127] Don't use boolean for property 'aether.updateCheckMan…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #62:
URL: https://github.com/apache/maven-resolver/pull/62
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org