You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jonathan Locke (JIRA)" <ji...@apache.org> on 2007/03/14 21:46:10 UTC
[jira] Created: (WICKET-391) Fold BufferedWebResponse into
WebResponse to allow extension of both
Fold BufferedWebResponse into WebResponse to allow extension of both
--------------------------------------------------------------------
Key: WICKET-391
URL: https://issues.apache.org/jira/browse/WICKET-391
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.3
Reporter: Jonathan Locke
Fix For: 1.3
currently our webresponse subclasses are not extensible because they are dynamically picked when constructed by the factory method in session based on application settings. we should consider folding bufferedwebresponse into webresponse. we would lazy init the appendingstringbuffer to avoid constructing that unless buffering is required and provide a boolean setter to turn on/off buffering (that's probably where the buffer init should happen).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-391) Fold BufferedWebResponse into
WebResponse to allow extension of both
Posted by "Jonathan Locke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483069 ]
Jonathan Locke commented on WICKET-391:
---------------------------------------
Well, setter was probably a bad idea, but we could have just one WebResponse class that decides whether to buffer automatically based on settings. That way we don't have this code:
protected WebResponse newWebResponse(final HttpServletResponse servletResponse)
{
return (getRequestCycleSettings().getBufferResponse() ? new BufferedWebResponse(
servletResponse) : new WebResponse(servletResponse));
}
With this code, to create my own response subclass, I would have to duplicate this logic and cut and paste to extend both BufferedWebResponse and WebResponse. What I'd like to be able to do is just extend WebResponse and know it will work no matter what the settings are.
> Fold BufferedWebResponse into WebResponse to allow extension of both
> --------------------------------------------------------------------
>
> Key: WICKET-391
> URL: https://issues.apache.org/jira/browse/WICKET-391
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3
> Reporter: Jonathan Locke
> Fix For: 1.3
>
>
> currently our webresponse subclasses are not extensible because they are dynamically picked when constructed by the factory method in session based on application settings. we should consider folding bufferedwebresponse into webresponse. we would lazy init the appendingstringbuffer to avoid constructing that unless buffering is required and provide a boolean setter to turn on/off buffering (that's probably where the buffer init should happen).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-391) Fold BufferedWebResponse into
WebResponse to allow extension of both
Posted by "Jonathan Locke (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503249 ]
Jonathan Locke commented on WICKET-391:
---------------------------------------
yeah. post 1.3 is fine.
> Fold BufferedWebResponse into WebResponse to allow extension of both
> --------------------------------------------------------------------
>
> Key: WICKET-391
> URL: https://issues.apache.org/jira/browse/WICKET-391
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Reporter: Jonathan Locke
> Fix For: 1.4.0-alpha
>
>
> currently our webresponse subclasses are not extensible because they are dynamically picked when constructed by the factory method in session based on application settings. we should consider folding bufferedwebresponse into webresponse. we would lazy init the appendingstringbuffer to avoid constructing that unless buffering is required and provide a boolean setter to turn on/off buffering (that's probably where the buffer init should happen).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-391) Fold BufferedWebResponse into
WebResponse to allow extension of both
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-391:
--------------------------------
Fix Version/s: 1.4.0-alpha
Am I correct in assuming this isn't going to come before 1.4/2.0?
> Fold BufferedWebResponse into WebResponse to allow extension of both
> --------------------------------------------------------------------
>
> Key: WICKET-391
> URL: https://issues.apache.org/jira/browse/WICKET-391
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3.0-beta1
> Reporter: Jonathan Locke
> Fix For: 1.4.0-alpha
>
>
> currently our webresponse subclasses are not extensible because they are dynamically picked when constructed by the factory method in session based on application settings. we should consider folding bufferedwebresponse into webresponse. we would lazy init the appendingstringbuffer to avoid constructing that unless buffering is required and provide a boolean setter to turn on/off buffering (that's probably where the buffer init should happen).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-391) Fold BufferedWebResponse into
WebResponse to allow extension of both
Posted by "Alastair Maw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alastair Maw updated WICKET-391:
--------------------------------
Fix Version/s: (was: trunk)
> Fold BufferedWebResponse into WebResponse to allow extension of both
> --------------------------------------------------------------------
>
> Key: WICKET-391
> URL: https://issues.apache.org/jira/browse/WICKET-391
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: trunk
> Reporter: Jonathan Locke
>
> currently our webresponse subclasses are not extensible because they are dynamically picked when constructed by the factory method in session based on application settings. we should consider folding bufferedwebresponse into webresponse. we would lazy init the appendingstringbuffer to avoid constructing that unless buffering is required and provide a boolean setter to turn on/off buffering (that's probably where the buffer init should happen).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-391) Fold BufferedWebResponse into
WebResponse to allow extension of both
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12483060 ]
Johan Compagner commented on WICKET-391:
----------------------------------------
when to call this boolean setter?
Can it be called (true) when there is already something written?
and if it was true and you say false then it should immediately flush also the buffer?
Why do you want to be able to switch?
> Fold BufferedWebResponse into WebResponse to allow extension of both
> --------------------------------------------------------------------
>
> Key: WICKET-391
> URL: https://issues.apache.org/jira/browse/WICKET-391
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3
> Reporter: Jonathan Locke
> Fix For: 1.3
>
>
> currently our webresponse subclasses are not extensible because they are dynamically picked when constructed by the factory method in session based on application settings. we should consider folding bufferedwebresponse into webresponse. we would lazy init the appendingstringbuffer to avoid constructing that unless buffering is required and provide a boolean setter to turn on/off buffering (that's probably where the buffer init should happen).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.