You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/01/03 14:36:26 UTC
[GitHub] [shardingsphere-elasticjob] codecov-commenter edited a comment on pull request #2033: Decoupling ZooKeeper Curator from elasticjob-lite-core

codecov-commenter edited a comment on pull request #2033:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2033#issuecomment-1004118541


   # [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2033?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2033](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2033?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c7c3277) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/b7f2bf275afd2c36456e0f00bfe5b74622b2d6e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b7f2bf2) will **decrease** coverage by `0.47%`.
   > The diff coverage is `66.66%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2033/graphs/tree.svg?width=650&height=150&src=pr&token=8ZMVc4Yo4Z&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2033?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2033      +/-   ##
   ============================================
   - Coverage     85.70%   85.23%   -0.48%     
   - Complexity     1876     1879       +3     
   ============================================
     Files           278      280       +2     
     Lines          6066     6041      -25     
     Branches        728      665      -63     
   ============================================
   - Hits           5199     5149      -50     
   - Misses          535      584      +49     
   + Partials        332      308      -24     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2033?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...gsphere/elasticjob/reg/exception/RegException.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2033/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlZ2lzdHJ5LWNlbnRlci9lbGFzdGljam9iLXJlZ2lzdHJ5LWNlbnRlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVnL2V4Y2VwdGlvbi9SZWdFeGNlcHRpb24uamF2YQ==) | `100.00% <ø> (ø)` | |
   | [.../listener/ConnectionStateChangedEventListener.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2033/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlZ2lzdHJ5LWNlbnRlci9lbGFzdGljam9iLXJlZ2lzdHJ5LWNlbnRlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVnL2xpc3RlbmVyL0Nvbm5lY3Rpb25TdGF0ZUNoYW5nZWRFdmVudExpc3RlbmVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...here/elasticjob/reg/listener/DataChangedEvent.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2033/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlZ2lzdHJ5LWNlbnRlci9lbGFzdGljam9iLXJlZ2lzdHJ5LWNlbnRlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVnL2xpc3RlbmVyL0RhdGFDaGFuZ2VkRXZlbnQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...ticjob/reg/zookeeper/ZookeeperElectionService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2033/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlZ2lzdHJ5LWNlbnRlci9lbGFzdGljam9iLXJlZ2l0cnktY2VudGVyLXByb3ZpZGVyL2VsYXN0aWNqb2ItcmVnaXN0cnktY2VudGVyLXpvb2tlZXBlci1jdXJhdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL3JlZy96b29rZWVwZXIvWm9va2VlcGVyRWxlY3Rpb25TZXJ2aWNlLmphdmE=) | `84.61% <ø> (ø)` | |
   | [...asticjob/lite/internal/election/LeaderService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2033/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvZWxlY3Rpb24vTGVhZGVyU2VydmljZS5qYXZh) | `95.65% <ø> (-0.19%)` | :arrow_down: |
   | [...ticjob/lite/internal/failover/FailoverService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2033/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvZmFpbG92ZXIvRmFpbG92ZXJTZXJ2aWNlLmphdmE=) | `94.11% <ø> (-0.09%)` | :arrow_down: |
   | [...ite/internal/listener/AbstractListenerManager.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2033/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvbGlzdGVuZXIvQWJzdHJhY3RMaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...sticjob/reg/zookeeper/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2033/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlZ2lzdHJ5LWNlbnRlci9lbGFzdGljam9iLXJlZ2l0cnktY2VudGVyLXByb3ZpZGVyL2VsYXN0aWNqb2ItcmVnaXN0cnktY2VudGVyLXpvb2tlZXBlci1jdXJhdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL3JlZy96b29rZWVwZXIvWm9va2VlcGVyUmVnaXN0cnlDZW50ZXIuamF2YQ==) | `62.29% <39.65%> (ø)` | |
   | [...sticjob/lite/api/registry/JobInstanceRegistry.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2033/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvYXBpL3JlZ2lzdHJ5L0pvYkluc3RhbmNlUmVnaXN0cnkuamF2YQ==) | `44.44% <50.00%> (-0.39%)` | :arrow_down: |
   | [...ite/internal/sharding/ShardingListenerManager.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2033/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2hhcmRpbmcvU2hhcmRpbmdMaXN0ZW5lck1hbmFnZXIuamF2YQ==) | `88.88% <66.66%> (-0.40%)` | :arrow_down: |
   | ... and [66 more](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2033/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2033?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2033?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b7f2bf2...c7c3277](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2033?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org