You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Toni Menzel (JIRA)" <ji...@apache.org> on 2009/07/07 21:44:15 UTC
[jira] Created: (FELIX-1307) Log situation in DeploymentAdmin impl
very unclear
Log situation in DeploymentAdmin impl very unclear
--------------------------------------------------
Key: FELIX-1307
URL: https://issues.apache.org/jira/browse/FELIX-1307
Project: Felix
Issue Type: Improvement
Components: Deployment Admin
Reporter: Toni Menzel
Priority: Trivial
e.g. StartBundleCommand.java :
has this:
// TODO: m_log.log(LogService.LOG_DEBUG, "won't wait for Packages refreshed event, event is already received");
all over the place.
And not just this one.
Question: what is the intend of commenting this out ? What is the plan here ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FELIX-1307) Log situation in DeploymentAdmin impl
very unclear
Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marcel Offermans reassigned FELIX-1307:
---------------------------------------
Assignee: Marcel Offermans
> Log situation in DeploymentAdmin impl very unclear
> --------------------------------------------------
>
> Key: FELIX-1307
> URL: https://issues.apache.org/jira/browse/FELIX-1307
> Project: Felix
> Issue Type: Improvement
> Components: Deployment Admin
> Reporter: Toni Menzel
> Assignee: Marcel Offermans
> Priority: Trivial
>
> e.g. StartBundleCommand.java :
> has this:
> // TODO: m_log.log(LogService.LOG_DEBUG, "won't wait for Packages refreshed event, event is already received");
> all over the place.
> And not just this one.
> Question: what is the intend of commenting this out ? What is the plan here ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FELIX-1307) Log situation in DeploymentAdmin
impl very unclear
Posted by "Marcel Offermans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FELIX-1307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12741894#action_12741894 ]
Marcel Offermans commented on FELIX-1307:
-----------------------------------------
There is some infrastructure for logging in place:
- DeploymentAdminImpl already gets injected with a LogService
- DeploymentSessionImpl has access to this injected member
This gets the logging all the way into the Commands (or at least into the execute method of a Command).
Basically, what needs to be done is to implement sensible logging messages in the right locations. The comments are probably left over from a previous implementation as these clearly can't work anymore like this.
> Log situation in DeploymentAdmin impl very unclear
> --------------------------------------------------
>
> Key: FELIX-1307
> URL: https://issues.apache.org/jira/browse/FELIX-1307
> Project: Felix
> Issue Type: Improvement
> Components: Deployment Admin
> Reporter: Toni Menzel
> Assignee: Marcel Offermans
> Priority: Trivial
>
> e.g. StartBundleCommand.java :
> has this:
> // TODO: m_log.log(LogService.LOG_DEBUG, "won't wait for Packages refreshed event, event is already received");
> all over the place.
> And not just this one.
> Question: what is the intend of commenting this out ? What is the plan here ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.