You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org> on 2007/03/05 13:30:51 UTC
[jira] Created: (WICKET-358) Properly decode URLs
Properly decode URLs
--------------------
Key: WICKET-358
URL: https://issues.apache.org/jira/browse/WICKET-358
Project: Wicket
Issue Type: Bug
Components: wicket
Reporter: Jean-Baptiste Quenot
Assigned To: Jean-Baptiste Quenot
There are places where Wicket decodes an URL and builds a Map of parameters:
* Form.FormDispatchRequest(Request, String)
* WebRequestWithCryptedUrl(HttpServletRequest) (deprecated class)
* MockHttpServletRequest
* AutoLinkResolver
Sometimes, String arrays are not properly handled. Sometimes the parameters are not URL-decoded. Sometimes the empty values are not properly handled. The idea is to remove duplicate code and provide a centralized piece of code to decode an URL.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-358) Properly decode URLs
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Quenot updated WICKET-358:
----------------------------------------
Attachment: 20070305-wicket-1.x-decode-request-parameters.txt
> Properly decode URLs
> --------------------
>
> Key: WICKET-358
> URL: https://issues.apache.org/jira/browse/WICKET-358
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Jean-Baptiste Quenot
> Assigned To: Jean-Baptiste Quenot
> Attachments: 20070305-wicket-1.x-decode-request-parameters.txt
>
>
> There are places where Wicket decodes an URL and builds a Map of parameters:
> * Form.FormDispatchRequest(Request, String)
> * WebRequestWithCryptedUrl(HttpServletRequest) (deprecated class)
> * MockHttpServletRequest
> * AutoLinkResolver
> Sometimes, String arrays are not properly handled. Sometimes the parameters are not URL-decoded. Sometimes the empty values are not properly handled. The idea is to remove duplicate code and provide a centralized piece of code to decode an URL.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-358) Properly decode URLs
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478324 ]
Jean-Baptiste Quenot commented on WICKET-358:
---------------------------------------------
Done in 1.x, need to port to trunk
> Properly decode URLs
> --------------------
>
> Key: WICKET-358
> URL: https://issues.apache.org/jira/browse/WICKET-358
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Jean-Baptiste Quenot
> Assigned To: Jean-Baptiste Quenot
> Attachments: 20070305-wicket-1.x-decode-request-parameters.txt, 20070305-wicket-1.x-decode-request-parameters.txt, 20070305-wicket-1.x-decode-request-parameters.txt
>
>
> There are places where Wicket decodes an URL and builds a Map of parameters:
> * Form.FormDispatchRequest(Request, String)
> * WebRequestWithCryptedUrl(HttpServletRequest) (deprecated class)
> * MockHttpServletRequest
> * AutoLinkResolver
> * PageParameters(String, String)
> * CryptedUrlWebRequestCodingStrategy
> Sometimes, String arrays are not properly handled. Sometimes the parameters are not URL-decoded. Sometimes the empty values are not properly handled. The idea is to remove duplicate code and provide a centralized piece of code to decode an URL.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-358) Properly decode URLs
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Quenot updated WICKET-358:
----------------------------------------
Fix Version/s: (was: trunk)
1.3.0-beta1
> Properly decode URLs
> --------------------
>
> Key: WICKET-358
> URL: https://issues.apache.org/jira/browse/WICKET-358
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Jean-Baptiste Quenot
> Assignee: Jean-Baptiste Quenot
> Fix For: 1.3.0-beta1, 2.0 branch (discontinued)
>
> Attachments: 20070305-wicket-1.x-decode-request-parameters.txt, 20070305-wicket-1.x-decode-request-parameters.txt, 20070305-wicket-1.x-decode-request-parameters.txt
>
>
> There are places where Wicket decodes an URL and builds a Map of parameters:
> * Form.FormDispatchRequest(Request, String)
> * WebRequestWithCryptedUrl(HttpServletRequest) (deprecated class)
> * MockHttpServletRequest
> * AutoLinkResolver
> * PageParameters(String, String)
> * CryptedUrlWebRequestCodingStrategy
> Sometimes, String arrays are not properly handled. Sometimes the parameters are not URL-decoded. Sometimes the empty values are not properly handled. The idea is to remove duplicate code and provide a centralized piece of code to decode an URL.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-358) Properly decode URLs
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Quenot updated WICKET-358:
----------------------------------------
Attachment: 20070305-wicket-1.x-decode-request-parameters.txt
Handle empty values correctly
> Properly decode URLs
> --------------------
>
> Key: WICKET-358
> URL: https://issues.apache.org/jira/browse/WICKET-358
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Jean-Baptiste Quenot
> Assigned To: Jean-Baptiste Quenot
> Attachments: 20070305-wicket-1.x-decode-request-parameters.txt, 20070305-wicket-1.x-decode-request-parameters.txt, 20070305-wicket-1.x-decode-request-parameters.txt
>
>
> There are places where Wicket decodes an URL and builds a Map of parameters:
> * Form.FormDispatchRequest(Request, String)
> * WebRequestWithCryptedUrl(HttpServletRequest) (deprecated class)
> * MockHttpServletRequest
> * AutoLinkResolver
> * PageParameters(String, String)
> * CryptedUrlWebRequestCodingStrategy
> Sometimes, String arrays are not properly handled. Sometimes the parameters are not URL-decoded. Sometimes the empty values are not properly handled. The idea is to remove duplicate code and provide a centralized piece of code to decode an URL.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-358) Properly decode URLs
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Quenot resolved WICKET-358.
-----------------------------------------
Resolution: Fixed
Fix Version/s: 2.0
1.3
> Properly decode URLs
> --------------------
>
> Key: WICKET-358
> URL: https://issues.apache.org/jira/browse/WICKET-358
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Jean-Baptiste Quenot
> Assigned To: Jean-Baptiste Quenot
> Fix For: 1.3, 2.0
>
> Attachments: 20070305-wicket-1.x-decode-request-parameters.txt, 20070305-wicket-1.x-decode-request-parameters.txt, 20070305-wicket-1.x-decode-request-parameters.txt
>
>
> There are places where Wicket decodes an URL and builds a Map of parameters:
> * Form.FormDispatchRequest(Request, String)
> * WebRequestWithCryptedUrl(HttpServletRequest) (deprecated class)
> * MockHttpServletRequest
> * AutoLinkResolver
> * PageParameters(String, String)
> * CryptedUrlWebRequestCodingStrategy
> Sometimes, String arrays are not properly handled. Sometimes the parameters are not URL-decoded. Sometimes the empty values are not properly handled. The idea is to remove duplicate code and provide a centralized piece of code to decode an URL.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-358) Properly decode URLs
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Quenot updated WICKET-358:
----------------------------------------
Attachment: 20070305-wicket-1.x-decode-request-parameters.txt
Also change CryptedUrlWebRequestCodingStrategy, and deprecate PageParameters(String, String) which is meant to be used for decoding URL parameters.
> Properly decode URLs
> --------------------
>
> Key: WICKET-358
> URL: https://issues.apache.org/jira/browse/WICKET-358
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Jean-Baptiste Quenot
> Assigned To: Jean-Baptiste Quenot
> Attachments: 20070305-wicket-1.x-decode-request-parameters.txt, 20070305-wicket-1.x-decode-request-parameters.txt
>
>
> There are places where Wicket decodes an URL and builds a Map of parameters:
> * Form.FormDispatchRequest(Request, String)
> * WebRequestWithCryptedUrl(HttpServletRequest) (deprecated class)
> * MockHttpServletRequest
> * AutoLinkResolver
> * PageParameters(String, String)
> * CryptedUrlWebRequestCodingStrategy
> Sometimes, String arrays are not properly handled. Sometimes the parameters are not URL-decoded. Sometimes the empty values are not properly handled. The idea is to remove duplicate code and provide a centralized piece of code to decode an URL.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-358) Properly decode URLs
Posted by "Johan Compagner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478286 ]
Johan Compagner commented on WICKET-358:
----------------------------------------
what about BookmarkablePageRequestTargetUrlCodingStrategy.appendParameters(AppendingStringBuffer url, Map parameters)
where we call String escapedValue = urlEncode(entry.getValue().toString()); (also done in QueryStringUrlCodingStrategy)
> Properly decode URLs
> --------------------
>
> Key: WICKET-358
> URL: https://issues.apache.org/jira/browse/WICKET-358
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Jean-Baptiste Quenot
> Assigned To: Jean-Baptiste Quenot
> Attachments: 20070305-wicket-1.x-decode-request-parameters.txt, 20070305-wicket-1.x-decode-request-parameters.txt, 20070305-wicket-1.x-decode-request-parameters.txt
>
>
> There are places where Wicket decodes an URL and builds a Map of parameters:
> * Form.FormDispatchRequest(Request, String)
> * WebRequestWithCryptedUrl(HttpServletRequest) (deprecated class)
> * MockHttpServletRequest
> * AutoLinkResolver
> * PageParameters(String, String)
> * CryptedUrlWebRequestCodingStrategy
> Sometimes, String arrays are not properly handled. Sometimes the parameters are not URL-decoded. Sometimes the empty values are not properly handled. The idea is to remove duplicate code and provide a centralized piece of code to decode an URL.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-358) Properly decode URLs
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478311 ]
Jean-Baptiste Quenot commented on WICKET-358:
---------------------------------------------
Johan: this issue is only about decoding an URL into a ValueMap. But thanks for pointing me to BookmarkablePageRequestTargetUrlCodingStrategy, actually there is yet another decoding method in AbstractRequestTargetUrlCodingStrategy.decodeParameters(String, Map) that uses slashes instead of ampersand and equal signs. However it seems to properly handle URL decoding and String arrays, and because of the slashes it is too specific to merge it with another existing method.
> Properly decode URLs
> --------------------
>
> Key: WICKET-358
> URL: https://issues.apache.org/jira/browse/WICKET-358
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Jean-Baptiste Quenot
> Assigned To: Jean-Baptiste Quenot
> Attachments: 20070305-wicket-1.x-decode-request-parameters.txt, 20070305-wicket-1.x-decode-request-parameters.txt, 20070305-wicket-1.x-decode-request-parameters.txt
>
>
> There are places where Wicket decodes an URL and builds a Map of parameters:
> * Form.FormDispatchRequest(Request, String)
> * WebRequestWithCryptedUrl(HttpServletRequest) (deprecated class)
> * MockHttpServletRequest
> * AutoLinkResolver
> * PageParameters(String, String)
> * CryptedUrlWebRequestCodingStrategy
> Sometimes, String arrays are not properly handled. Sometimes the parameters are not URL-decoded. Sometimes the empty values are not properly handled. The idea is to remove duplicate code and provide a centralized piece of code to decode an URL.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-358) Properly decode URLs
Posted by "Jean-Baptiste Quenot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jean-Baptiste Quenot updated WICKET-358:
----------------------------------------
Description:
There are places where Wicket decodes an URL and builds a Map of parameters:
* Form.FormDispatchRequest(Request, String)
* WebRequestWithCryptedUrl(HttpServletRequest) (deprecated class)
* MockHttpServletRequest
* AutoLinkResolver
* PageParameters(String, String)
* CryptedUrlWebRequestCodingStrategy
Sometimes, String arrays are not properly handled. Sometimes the parameters are not URL-decoded. Sometimes the empty values are not properly handled. The idea is to remove duplicate code and provide a centralized piece of code to decode an URL.
was:
There are places where Wicket decodes an URL and builds a Map of parameters:
* Form.FormDispatchRequest(Request, String)
* WebRequestWithCryptedUrl(HttpServletRequest) (deprecated class)
* MockHttpServletRequest
* AutoLinkResolver
Sometimes, String arrays are not properly handled. Sometimes the parameters are not URL-decoded. Sometimes the empty values are not properly handled. The idea is to remove duplicate code and provide a centralized piece of code to decode an URL.
> Properly decode URLs
> --------------------
>
> Key: WICKET-358
> URL: https://issues.apache.org/jira/browse/WICKET-358
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Reporter: Jean-Baptiste Quenot
> Assigned To: Jean-Baptiste Quenot
> Attachments: 20070305-wicket-1.x-decode-request-parameters.txt
>
>
> There are places where Wicket decodes an URL and builds a Map of parameters:
> * Form.FormDispatchRequest(Request, String)
> * WebRequestWithCryptedUrl(HttpServletRequest) (deprecated class)
> * MockHttpServletRequest
> * AutoLinkResolver
> * PageParameters(String, String)
> * CryptedUrlWebRequestCodingStrategy
> Sometimes, String arrays are not properly handled. Sometimes the parameters are not URL-decoded. Sometimes the empty values are not properly handled. The idea is to remove duplicate code and provide a centralized piece of code to decode an URL.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.